search

paginagmbh / redmine_lightbox2

Lightbox for image attachments in Redmine
MIT License
126 stars 97 forks source link

Update lightbox.js #52

Closed namezero111111 closed 6 years ago

namezero111111 commented 6 years ago

Fixes thumbnail preview selection for Redmine 3.4

tofi86 commented 6 years ago

Can you tell a bit more what this proposed fix is doing? On which page does it improve thumbnail display?

namezero111111 commented 6 years ago

In our new Redmine 3.4.4 test environment, the image link here is inside the "div.journal.attachment a" rather than "div.journal div.thumbnails a". This causes the lightbox to display an error message, because the /download/ part is not subsituted. untitled Image after the patch. Before, the following is rendered and causes the error: href="/attachments/15/Untitled.png"

namezero111111 commented 6 years ago

This occurs if another plugin, redmine_inline_note_images is used. Apparently this has become obsolete with the thumbnail option in Settings->Display.

tofi86 commented 6 years ago

Alright, thanks anyways for the explanation :-)