search

pahen / madge

Create graphs from your CommonJS, AMD or ES6 module dependencies
MIT License
9.09k stars 317 forks source link

Add some collaborator to maintain this package #334

Open PabloLION opened 2 years ago

PabloLION commented 2 years ago

As discussed in https://github.com/pahen/madge/pull/319#issuecomment-1311466429, this repo is currently down for maintenance and we have 0 issue solved / PR merged in the last month (See here https://github.com/pahen/madge/pulse/monthly)

I believe that this repo needs some helping hands from the community. As I have no experience maintaining any popular package, maybe some more senior ones can help with this?

kamiazya commented 1 year ago

Hi, @pahen @PabloLION

I became interested in this project through developing #341 and discovered this issue while researching.

I am not sure if I am qualified to be a maintainer for a project of this size, but I may be able to help since I develop some npm library.

I can't commit to helping forever either, but how about trying to help out by focusing on maintaining?

Since I can't see the status of my work and personal activities yet, I will try to volunteer until the end of March 2023 to work on fixing high priority bugs like Node.js 18 support.

(It would be beneficial for me to contribute to this project, especially since getting #341 merged will increase the use of my project.)

Thanks.

PabloLION commented 1 year ago

Hi @kamiazya . I'm happy to see that someone can help maintaining this, but I can't do anything. Maybe you can create a fork? I do remember that @pahen , the owner, said he might be back Jan 2023 (in #319) so maybe we just wait a little more.

pahen commented 1 year ago

Hi and sorry for not responding! I've now added you both as collaborators to this repo @kamiazya @PabloLION

kamiazya commented 1 year ago

@pahen Thank you very much.

I will try to focus on maintenance for a while, as per the above policy.

pahen commented 1 year ago

@pahen Thank you very much.

I will try to focus on maintenance for a while, as per the above policy.

Thank you! 🥇

kamiazya commented 1 year ago

@pahen I want to merge and release the first pull request you approve, is that okay?

I assume CircleCI is supposed to automatically release the package.json when the version changes, but please let me know if there is another way :pray:

(Edit) Or let me know if there is anything you would like me to do :pray:

pahen commented 1 year ago

The release step is done manually today. I'll add a NPM task to create a release and publish it to NPM to make it easier. PR is coming.

PabloLION commented 1 year ago

@kamiazya I think we should start to handling PRs now? I tried to reach you via twitter but it seems you've blocked DM from strangers. can you check my PR https://github.com/pahen/madge/pull/319 ?

pahen commented 1 year ago

I've added docs about creating releases now in https://github.com/pahen/madge#creating-a-release @kamiazya @PabloLION

PabloLION commented 1 year ago

Thanks @pahen ! Will work on it later.

kamiazya commented 1 year ago

@PabloLION DM is now open! Also reviewed and Approved #319.

kamiazya commented 1 year ago

@pahen @PabloLION I would start merging those with more than one Approve for Owner or Collaborator.

I will merge #342, but the release of 4.0.0, which previously raised the minimum version of Node.js, was done with a major version upgrade so I will follow that policy and release the next version at 6.0.0.

kamiazya commented 1 year ago

@pahen @PabloLION I have created a milestone to align our perceptions about the release target for v6.0.0.

Please let us know if you have any concerns!

kamiazya commented 1 year ago

Once #321 is merged, it will be ready for release.

Requested @PabloLION to review #321.

@pahen @PabloLION Also, since release is a different topic than the issue title, why don't we move it to GitHub Discussions?

vikingair commented 1 year ago

Great job @kamiazya thanks for pushing so actively. I was also added as collaborator. Because of my newborn and new projects I will not have plenty of time, but I am willing to support this project, too 👍

kamiazya commented 1 year ago

I created this issue #347 to discuss the pros and cons of releasing v6.0.0.

PabloLION commented 1 year ago

Nice works @kamiazya . And GitHub Discussions seems good. Could you please activate it @pahen?

PabloLION commented 1 year ago

I'm now trying to label all the issues, and I feel this one can be closed already. As we are the current collaborators, @kamiazya, please close it if you feel the same.

kamiazya commented 1 year ago

I feel that there are still some issues where the project is still in the genus. In order to make this a sustainable community in the future, I think we need to discuss this with more people.

I want to keep this open for a while :pray:

legobeat commented 1 year ago

My day job depends on madge and I have some experience with maintenance. I think it's great of @kamiazya and @PabloLION to take the lead here - just letting you know that you may @ me here if I may be of assistance to unblock anything for now.