pal-robotics / tiago_simulation

http://wiki.ros.org/Robots/TIAGo
Apache License 2.0
33 stars 28 forks source link

octomap modifications for simulation #2

Closed AleDF closed 7 years ago

bmagyar commented 7 years ago

So this exposes the camera parameter move_group to the top level. It's only my 2 cents but for something like this to be merged the top-level parameter name should be more specific. At the move_group.launch level it's obvious what this is about but anywhere else it is pretty much a random name.

use_moveit_camera instead maybe? or something similar

AleDF commented 7 years ago

yes can be a good hint, thanks