search

pal-robotics / tiago_simulation

http://wiki.ros.org/Robots/TIAGo
Apache License 2.0
41 stars 34 forks source link

ROS 1 example on humble-devel branch #24

Closed jkaniuka closed 1 year ago

jkaniuka commented 1 year ago

Hi :wave:,

I noticed that on the humble-devel branch there is a file grasp_demo.py, which is an example that uses ROS 1. However, the second example in that directory (tuck_arm.py) does already use ROS 2. I suspect that this is just an oversight, but it may be confusing to beginners that on the branch regarding ROS 2 there is an example that uses ROS 1.

Regards, Jan

saikishor commented 1 year ago

Hello @jkaniuka,

Thank you for writing to us. We have the script as a part of the migration that needs to be done. However, when you compile the package, the part of the grasp_demo.py script is not installed as per the install rules defined in the CMakeLists.txt. At the same time, we understand this might be confusing for beginners. We will consider doing a cleanup soon.

Thank you,

Best Regards, PAL Robotics Team.

jkaniuka commented 1 year ago

Great, good luck on the migration to ROS 2 :wink: