[Checkbox] using non-callback inputRef fails with "Cannot add property indeterminate, object is not extensible" at runtime

palantir / blueprint

A React-based UI toolkit for the web

https://blueprintjs.com/

Apache License 2.0

20.75k stars 2.18k forks source link

Closed vladimir-djokic closed 3 years ago

vladimir-djokic commented 3 years ago

Package version(s):
- @blueprintjs/core 3.42.0
- react 17.0.2
Operating System: Windows 10 x64
Browser name and version: Microsoft Edge Version 91.0.852.0 (Official build) dev (64-bit)

If non-callback ref is used for inputRef, "Cannot add property indeterminate, object is not extensible" is thrown.

Use callback ref.

adidahiya commented 3 years ago

Your sandbox seems to work fine with the latest version of Blueprint core v3.43.0: https://codesandbox.io/s/blueprint-sandbox-forked-es5qi?file=/src/index.tsx

vladimir-djokic commented 3 years ago

Yes, I can confirm that the issue is not present in 3.43.0 and 3.44.0, but present in earlier versions.

adidahiya commented 3 years ago

Indeed, I believe it was fixed by https://github.com/palantir/blueprint/pull/4612, released in 3.43.0