search

palantir / cassandra

Palantir's fork of Apache Cassandra
Apache License 2.0
10 stars 7 forks source link

regenerate interface code on thrift 0.17.0 #577

Open tpetracca opened 3 weeks ago

tpetracca commented 3 weeks ago

In https://github.com/palantir/cassandra/pull/432 we manually modified the generated code in order to bump the runtime dependency on libthrift to 0.17.0, so now we can't make changes to thrift and re-generate without having to re-apply the manual changes.

This change updates the code-gen to be generated from thrift 0.17.0, which shouldn't require the manual changes anymore.

In order to install thrift 0.17.0 locally I used an old git commit of the Homebrew source and installed from like this...

homebrew-core tpetracca$ git remote -v
origin  https://github.com/Homebrew/homebrew-core.git (fetch)
origin  https://github.com/Homebrew/homebrew-core.git (push)
### this commit hash is the last change to the thrift formula before they upgrade from 0.17.0 to 0.18.0
homebrew-core tpetracca$ git checkout 8f0b9dde69b560dbffad719e3a341fa3018cca7d
HEAD is now at 8f0b9dde69b thrift: brew style --fix
homebrew-core tpetracca$ brew install ./Formula/thrift.rb
... it installing ...
rhuffy commented 6 days ago

I attempted the codegen locally and it included a license header on each file. Are you intentionally removing those headers?

rhuffy commented 6 days ago

I've also created a homebrew tap that should make it easier install thrift in thrift in the future

brew install rhuffy/thrift/thrift@0.17