search

palantir / conjure-java

Conjure generator for Java clients and servers
Apache License 2.0
27 stars 43 forks source link

Fix externalFallbackTypes to also apply to endpoint return types #2225

Closed ash211 closed 6 months ago

ash211 commented 6 months ago

FLUP to https://github.com/palantir/conjure-java/pull/2213

Before this PR

Enabling externalFallbackTypes would erase external import types to their base type in most places, but not in the return type of endpoints.

After this PR

==COMMIT_MSG== Fix externalFallbackTypes to also apply to endpoint return types ==COMMIT_MSG==

Changes in this PR:

  1. Change ExternalImportFilter to also erase types for EndpointDefinition returns
  2. Enable UndertowServiceGenerator for the test. For fakes, I am using conjure-java-local not just to generate clients, but also to generate the server-side interface.
  3. Change ExternalLong in the test conjure file to point to an unknown reference. The classes in src/integrationInput are compiled as part of check, so this will help ensure these continue to compile in the future in the face of missing local classes.

Possible downsides?

None known

changelog-app[bot] commented 6 months ago

Generate changelog in changelog-dir>`changelog/@unreleased`</changelog-dir

What do the change types mean? - `feature`: A new feature of the service. - `improvement`: An incremental improvement in the functionality or operation of the service. - `fix`: Remedies the incorrect behaviour of a component of the service in a backwards-compatible way. - `break`: Has the potential to break consumers of this service's API, inclusive of both Palantir services and external consumers of the service's API (e.g. customer-written software or integrations). - `deprecation`: Advertises the intention to remove service functionality without any change to the operation of the service itself. - `manualTask`: Requires the possibility of manual intervention (running a script, eyeballing configuration, performing database surgery, ...) at the time of upgrade for it to succeed. - `migration`: A fully automatic upgrade migration task with no engineer input required. _Note: only one type should be chosen._
How are new versions calculated? - ❗The `break` and `manual task` changelog types will result in a major release! - 🐛 The `fix` changelog type will result in a minor release in most cases, and a patch release version for patch branches. This behaviour is configurable in autorelease. - ✨ All others will result in a minor version release.

Type

- [ ] Feature - [ ] Improvement - [x] Fix - [ ] Break - [ ] Deprecation - [ ] Manual task - [ ] Migration

Description

Fix externalFallbackTypes to also apply to endpoint return types **Check the box to generate changelog(s)** - [x] Generate changelog entry
svc-autorelease commented 6 months ago

Released 8.11.0