palantir / conjure-java

Conjure generator for Java clients and servers
Apache License 2.0
27 stars 43 forks source link

do not attempt to generate a dialog service if no endpoints #2237

Closed esword closed 6 months ago

esword commented 6 months ago

Before this PR

If a service had no declared endpoints the dialogue service generator fails trying to create the Endpoints enum. The poet library will not allow an empty enum class. All other generators handle things correctly.

After this PR

==COMMIT_MSG== Skips generating the Endpoints enum if no endpoints. ==COMMIT_MSG==

Possible downsides?

changelog-app[bot] commented 6 months ago

Generate changelog in changelog-dir>`changelog/@unreleased`</changelog-dir

What do the change types mean? - `feature`: A new feature of the service. - `improvement`: An incremental improvement in the functionality or operation of the service. - `fix`: Remedies the incorrect behaviour of a component of the service in a backwards-compatible way. - `break`: Has the potential to break consumers of this service's API, inclusive of both Palantir services and external consumers of the service's API (e.g. customer-written software or integrations). - `deprecation`: Advertises the intention to remove service functionality without any change to the operation of the service itself. - `manualTask`: Requires the possibility of manual intervention (running a script, eyeballing configuration, performing database surgery, ...) at the time of upgrade for it to succeed. - `migration`: A fully automatic upgrade migration task with no engineer input required. _Note: only one type should be chosen._
How are new versions calculated? - ❗The `break` and `manual task` changelog types will result in a major release! - 🐛 The `fix` changelog type will result in a minor release in most cases, and a patch release version for patch branches. This behaviour is configurable in autorelease. - ✨ All others will result in a minor version release.

Type

- [ ] Feature - [ ] Improvement - [x] Fix - [ ] Break - [ ] Deprecation - [ ] Manual task - [ ] Migration

Description

do not attempt to generate a dialog service if no endpoints **Check the box to generate changelog(s)** - [x] Generate changelog entry
svc-autorelease commented 6 months ago

Released 8.12.0