changelog-app[bot]
commented
6 months ago Generate changelog in changelog-dir>`changelog/@unreleased`</changelog-dir
What do the change types mean?
- `feature`: A new feature of the service. - `improvement`: An incremental improvement in the functionality or operation of the service. - `fix`: Remedies the incorrect behaviour of a component of the service in a backwards-compatible way. - `break`: Has the potential to break consumers of this service's API, inclusive of both Palantir services and external consumers of the service's API (e.g. customer-written software or integrations). - `deprecation`: Advertises the intention to remove service functionality without any change to the operation of the service itself. - `manualTask`: Requires the possibility of manual intervention (running a script, eyeballing configuration, performing database surgery, ...) at the time of upgrade for it to succeed. - `migration`: A fully automatic upgrade migration task with no engineer input required. _Note: only one type should be chosen._How are new versions calculated?
- ❗The `break` and `manual task` changelog types will result in a major release! - 🐛 The `fix` changelog type will result in a minor release in most cases, and a patch release version for patch branches. This behaviour is configurable in autorelease. - ✨ All others will result in a minor version release.Type
Description
mpritham
Before this PR
When the
nonNullCollectionsflag is enabled, the generated Conjure definitions do not check that null values cannot be added to collections.After this PR
==COMMIT_MSG== When
nonNullCollectionsis enabled, null-check values added to collections ==COMMIT_MSG==Possible downsides?
N/A
Alternative considered
In the generated object, we could hold a collection as a reference to a builder for a relevant implementation of Guava's ImmutableCollection interface. The
ImmutableCollectioninterface null-checks values, and we would not need to extendConjureCollections. This approach is more complicated due to the divergence in implementation from objects generated with and without thenonNullCollectionsflag.