Implement non null conjure collection [Primitive Arrays Pt. 1]

palantir / conjure-java

Conjure generator for Java clients and servers

Apache License 2.0

27 stars 43 forks source link

Implement non null conjure collection [Primitive Arrays Pt. 1] #2279

Closed Shibi-bala closed 5 months ago

Shibi-bala commented 5 months ago

Before this PR

This adds null value checking when using the nonNullCollections flag. In a subsequent PR, I'll move primitive lists to use a different type-specific collection factory method

After this PR

==COMMIT_MSG== ==COMMIT_MSG==

Possible downsides?

carterkozak commented 5 months ago

Tagging @schlosna, since you've worked in ConjureCollections.java as well, in case you'd like to provide feedback here.

This change generally looks good to me. In terms of sequencing, sometimes I like to stage this sort of thing into a feature branch before merging, that way if we get to the specialized collections and find we wish we'd done something a little different, we can still change earlier parts without worrying about them being released/used in prod already. Up to you.

svc-autorelease commented 5 months ago

Released 8.20.0