Closed schlosna closed 2 months ago
I also don't think we want to merge into the roomba/jackson-canary
branch.
I also don't think we want to merge into the
roomba/jackson-canary
branch.
Updated to target the roomba/jackson
excavator branch for https://github.com/palantir/conjure-java/pull/2332
Before this PR
https://github.com/palantir/conjure-java/pull/2164#issuecomment-2253445505
UndertowServerEteTest.testListOfNull
is failing because the exception thrown when deserializing a Guava immutable collection with null values changed.https://github.com/FasterXML/jackson-datatypes-collections/pull/132
After this PR
==COMMIT_MSG== UndertowServiceEteTest handles Jackson 2.17 MismatchedInputException
Jackson < 2.17.0 throws
NullPointerException
resulting in HTTP 400. Jackson >= 2.17.0 throws "MismatchedInputException: GuavaCollection
of typecom.google.common.collect.ImmutableList<java.lang.String>
does not acceptnull
values" resulting in HTTP 422.==COMMIT_MSG==
Possible downsides?
As seen by the unit test, requests with
null
elements for collections that do not support nulls will result in HTTP422
Unprocessable Content rather than HTTP400
Bad Request.