search

palantir / conjure-python-client

Python client and JSON encoders for use with generated Conjure clients
Apache License 2.0
7 stars 20 forks source link

Fix: Do not overwrite the _version.py file if it already exists #139

Closed johnhany97 closed 1 year ago

johnhany97 commented 1 year ago

Before this PR

Everytime the package is installed, the script runs to determine the current version using git, if git is installed.

This has been causing problems in the conda-forge feedstock of this repo as it's not actually cloning the source code, but rather working off of the pypi distribution of this repo, hence overwriting it with a non-PEP440-compliant version and causing problems for consumers.

After this PR

==COMMIT_MSG== Do not overwrite the _version.py file if it already exists ==COMMIT_MSG==

Possible downsides?