Use type_of_union to determine the union variant

palantir / conjure-python

Conjure generator for Python clients

Apache License 2.0

19 stars 18 forks source link

Use type_of_union to determine the union variant #681

Closed jliu-palantir closed 1 year ago

jliu-palantir commented 1 year ago

Context on why this PR is necessary: https://support-jira.palantir.tech/browse/PDS-340288

Before this PR

After this PR

==COMMIT_MSG== Add type_of_union to the constructor of UnionType Use type_of_union to determine the union variant instead of checking if the value is None ==COMMIT_MSG==

Possible downsides?

Should be merged with https://github.com/palantir/conjure-python-client/pull/141

changelog-app[bot] commented 1 year ago

Generate changelog in changelog-dir>`changelog/@unreleased`</changelog-dir

Type

- [ ] Feature - [ ] Improvement - [ ] Fix - [ ] Break - [ ] Deprecation - [ ] Manual task - [ ] Migration

Description

Add type_of_union to the constructor of UnionType Use type_of_union to determine the union variant instead of checking if the value is None

**Check the box to generate changelog(s)** - [ ] Generate changelog entry

svc-autorelease commented 1 year ago

Released 4.5.0