palantir / conjure-python

Conjure generator for Python clients
Apache License 2.0
19 stars 18 forks source link

Add option to return none on unknown union variants #714

Closed markgrex closed 1 year ago

markgrex commented 1 year ago

Before this PR

See https://github.com/palantir/conjure-python-client/issues/129

https://github.com/palantir/conjure-python-client/pull/150 added the option in conjure-python-client to return None when encountering unknown union variants, but conjure-python doesn't include this option in the conjure generated code.

After this PR

This PR:

==COMMIT_MSG== Add option to return none on unknown union variants ==COMMIT_MSG==

Possible downsides?

changelog-app[bot] commented 1 year ago

Generate changelog in changelog-dir>`changelog/@unreleased`</changelog-dir

Type

- [ ] Feature - [x] Improvement - [ ] Fix - [ ] Break - [ ] Deprecation - [ ] Manual task - [ ] Migration

Description

Add option to return none on unknown union variants **Check the box to generate changelog(s)** - [x] Generate changelog entry
svc-autorelease commented 1 year ago

Released 4.8.0