palantir / conjure-python

Conjure generator for Python clients
Apache License 2.0
19 stars 18 forks source link

Add option to return none on unknown union variants #718

Closed markgrex closed 1 year ago

markgrex commented 1 year ago

Before this PR

See https://github.com/palantir/conjure-python-client/issues/129

https://github.com/palantir/conjure-python-client/pull/152 was a backport of https://github.com/palantir/conjure-python-client/pull/150 to add the option in conjure-python-client to return None when encountering unknown union variants. This PR was released in conjure-python-client 1.10.8

This PR is a backport of the changes in https://github.com/palantir/conjure-python/pull/714 to conjure-python 3.x

It may be easier to review this PR commit by commit.

After this PR

==COMMIT_MSG== Add option to return none on unknown union variants ==COMMIT_MSG==

Possible downsides?