palantir / conjure-python

Conjure generator for Python clients
Apache License 2.0
19 stars 18 forks source link

Use pythonic docstyle for conjure types' docs #780

Closed LorenzoMartini closed 7 months ago

LorenzoMartini commented 7 months ago

Before this PR

The docstring generation for python docs is outputting them in the format

"""
Docs
"""

While the proper pythonic way would be

"""Docs
"""

After this PR

Adapt docs generation to follow python docstyle. In addition to that, disallow any sequence of """ within the generated code to avoid accidentally escaping the doc string

==COMMIT_MSG== Use pythonic docstyle for conjure types' docs and disallow any sequence of """ within ==COMMIT_MSG==

Possible downsides?

changelog-app[bot] commented 7 months ago

Generate changelog in changelog-dir>`changelog/@unreleased`</changelog-dir

What do the change types mean? - `feature`: A new feature of the service. - `improvement`: An incremental improvement in the functionality or operation of the service. - `fix`: Remedies the incorrect behaviour of a component of the service in a backwards-compatible way. - `break`: Has the potential to break consumers of this service's API, inclusive of both Palantir services and external consumers of the service's API (e.g. customer-written software or integrations). - `deprecation`: Advertises the intention to remove service functionality without any change to the operation of the service itself. - `manualTask`: Requires the possibility of manual intervention (running a script, eyeballing configuration, performing database surgery, ...) at the time of upgrade for it to succeed. - `migration`: A fully automatic upgrade migration task with no engineer input required. _Note: only one type should be chosen._
How are new versions calculated? - ❗The `break` and `manual task` changelog types will result in a major release! - 🐛 The `fix` changelog type will result in a minor release in most cases, and a patch release version for patch branches. This behaviour is configurable in autorelease. - ✨ All others will result in a minor version release.

Type

- [ ] Feature - [x] Improvement - [ ] Fix - [ ] Break - [ ] Deprecation - [ ] Manual task - [ ] Migration

Description

Use pythonic docstyle for conjure types' docs and disallow any sequence of `"""` within **Check the box to generate changelog(s)** - [x] Generate changelog entry
svc-autorelease commented 7 months ago

Released 4.11.0