search

palantir / conjure-verification

A testing tool that ensures all Conjure clients and servers adhere to a common wire spec
Apache License 2.0
9 stars 6 forks source link

Readme: fix link to RFC 004 #516

Closed tdeitch closed 2 years ago

tdeitch commented 2 years ago

Before this PR

The link from the readme to RFC 004 is wrong (it uses the wrong branch name).

After this PR

==COMMIT_MSG== Readme: fix link to RFC 004 ==COMMIT_MSG==

Possible downsides?

Maybe we wanted to switch the default branch in palantir/conjure instead? Either way, I think it's worth fixing this unless that is imminent.

stale[bot] commented 2 years ago

This PR has been automatically marked as stale because it has not been touched in the last 14 days. If you'd like to keep it open, please leave a comment or add the 'long-lived' label, otherwise it'll be closed in 7 days.

tdeitch commented 2 years ago

Still relevant!

tdeitch commented 2 years ago

Looks like maybe checks don't work on this repo? Or do I have to do something special to make them work?

ferozco commented 2 years ago

ya looks like something is up with the repo. I just power merged the readme change for now. @carterkozak @CRogers for SA