Closed Gelio closed 5 years ago
Thanks for your interest in palantir/tslint-react, @Gelio! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request.
Would be fantastic to include your PR in tslint-react
. Any update on this? Thanks for your great work!
@gibbok Thank you 🙂 I see many people giving a thumbs-up on this PR, but a maintainer needs to review it. Considering the fact that Palantir is moving development resources from TSLint to ESLint, it may take a while 😟
That's a pity. I would rather keep the hooks rule in my repo to be able to develop it freely. I will close this PR
Sure, you're free to do that, and users can install your package and use extends: "tslint-react-hooks"
... that's exactly what that feature was designed for.
@Gelio do you mind me doing this copy paste job?
@sonhanguyen Hey :wave: Yes, I do mind. I would rather not copy paste the rule's code over to this project as it would lead to duplication. Updates would have to be applied twice. Thus, I would rather keep the hooks rule in the tslint-react-hooks repository
Thanks for reaching out and suggesting :slightly_smiling_face:
I created a rule for detecting improper uses of React Hooks. For more information about the rule take a look at the tslint-react-hooks repository.
This PR integrates the
react-hooks-nesting
into this repository.I built
tslint-react
with the newly added rule and it works correctly with bothreact-hooks-nesting
and built in this repository (example that reports bothreact-hooks-nesting
for using a hook insideif
andjsx-wrap-multiline
):tslint.json
contained only the following:This PR is related to #186.