search

palantirnet / palantir-behat-extension

Additional step definitions for testing Drupal sites using Behat.
1 stars 4 forks source link

Add a FieldContext to check for the existence of fields. #25

Open zendoodles opened 8 years ago

zendoodles commented 8 years ago

A rough conversion of what we used on booth: https://github.com/palantirnet/booth/blob/develop/features/bootstrap/FeatureContext.php#L116

Obviously still needs some work, but maybe a good place to start the discussion.

becw commented 8 years ago

We're trying to follow this field testing approach on AcademyHealth, too 💓 ... which is Drupal 8, so I think @patrickfweston and @Kbentham will be looking at this at some point.

patrickfweston commented 8 years ago

Yep! I've implemented it in my latest PR 😸 : https://github.com/palantirnet/academyhealth/blob/fdd0b2a95a82c7681450bb12c4ba936de9c91cad/features/bootstrap/FeatureContext.php

froboy commented 8 years ago

@mcarmichael21 and I have been working on some more tests on MCC. File fields don't have an "Add more" button, and checkboxes are also "multivalued" and need a test. Once those are solid we'll commit them here.

zendoodles commented 7 years ago

@froboy Could those additions be added in a follow-up so they do not block the merging of this PR? Or, if you've already got code for them, could you add it to this PR or as a PR against this PR?

cc @mcarmichael21

froboy commented 7 years ago

@zendoodles both of those things are finished and in https://github.com/palantirnet/mcc/blob/develop/features/bootstrap/FeatureContext.php#L128. I'll try and get those merged into this soon. There's a bunch of differences between these two. Would you want to review the code there and either figure out how it should be merged or let me know how you'd like it merged. Specifically, the whole "multivalued" column in the test def seems like a pretty big change.