Fix tox and GitHub actions settings

pallets-eco / flask-debugtoolbar

A toolbar overlay for debugging Flask applications

https://flask-debugtoolbar.readthedocs.io

BSD 3-Clause "New" or "Revised" License

953 stars 146 forks source link

Fix tox and GitHub actions settings #217

Closed greyli closed 1 year ago

greyli commented 1 year ago

Remove the branch constraint for pull request triggering
Use Python 3.12 for main tests
Use ubuntu-20.04 for Python 3.6 since it's been removed in ubuntu-latest
Remove Python 2.7 since it's not supported by GitHub Actions anymore (https://github.com/actions/setup-python/issues/672)
Add the missing setup-python step
Merge the pip install commands

greyli commented 1 year ago

What do you think about using single quotes around the name for all 3 Python 3.12 names? This would match the others.

It's OK since these names don't contain dots or whitespaces. Similar to the settings in Flask.

jeffwidman commented 1 year ago

Let's ship this, added a trivial inline code comment for clarity, hope you don't mind. If you do feel strongly about that, let me know so that in the future I know to wait for you.