search

pallets-eco / flask-debugtoolbar

A toolbar overlay for debugging Flask applications
https://flask-debugtoolbar.readthedocs.io
BSD 3-Clause "New" or "Revised" License
953 stars 146 forks source link

Fix the test for basic app #221

Closed greyli closed 1 year ago

greyli commented 1 year ago
  1. Update the test app

If I understand correctly, the debug toolbar will only be enabled if app.debug is True. So I added the DEBUG=True to the test app.

Related code: https://github.com/pallets-eco/flask-debugtoolbar/blob/2b8bf9cc449a95f442b99dfdfb6147fa1ae2230a/src/flask_debugtoolbar/__init__.py#L114

  1. Update the src/flask_debugtoolbar/__init__.py

Fix the two if statements to prevent the following errors:

>       if 'gzip' in response.headers.get('Content-Encoding'):
E       TypeError: argument of type 'NoneType' is not iterable

Since the response.headers.get('Content-Encoding') could be None.

With this PR, all the tests will be passed. The failed style checker will be fixed in #219

jeffwidman commented 1 year ago

I just merged https://github.com/pallets-eco/flask-debugtoolbar/pull/219 and rebased this, nice to see everything 🟢 !

jeffwidman commented 1 year ago

Now that these checks are all passing, I went ahead and enabled them all as required checks against master.

I have zero objections if for some reason another maintainer needs to temporarily override these and merge a PR, but obviously use your judgement as that should probably be the exception rather than the rule now that folks have gone to so much effort to bring us up to date.

cc @macnewbold @nickjj @greyli