git add tox.ini requirements/typing.txt

pallets / flask

The Python micro framework for building web applications.

https://flask.palletsprojects.com

BSD 3-Clause "New" or "Revised" License

68.2k stars 16.25k forks source link

git add tox.ini requirements/typing.txt #5552

Closed ComputerScienceGirl12 closed 3 months ago

ComputerScienceGirl12 commented 3 months ago

git commit -m "Replace mypy with pyright in tox.ini for consistent type checking"

ComputerScienceGirl12 commented 3 months ago

This PR addresses Issue #5537.

Changes:

Updated tox.ini to replace mypy with pyright for type checking.
Modified requirements/typing.txt to include pyright.
Ran pyright, which yielded no errors.

This change ensures consistency in type checking tools within the Flask project, aligning with the addition of pyright in version 3.0.3.

davidism commented 3 months ago

Thanks for looking at this. However, it needs more work. We want to run both tools. We want to install them from the lock file, not directly. I think we actually had it set up before but then it got removed for some reason. You can see the other Pallets repos for how it's set up there. However, just enabling it isn't sufficient either, you need to actually get the tests passing.