search

pambsoftware / beefcake

Training planner and logger for Android
1 stars 0 forks source link

Wrong routine length #2

Open windmueller opened 9 years ago

windmueller commented 9 years ago

If a routine is finished in the same minute as when it has been started, the duration is shown as -7199 minutes.

ripern commented 9 years ago

I can't reproduce it, for me it says 0 minutes. Can you reproduce it again?

windmueller commented 9 years ago

Yes, I can still reproduce it:

  1. In the workouts overview, create a new workout with "New workout log"
  2. Immediately finish the workout
  3. Open the workout and inspect the random wrong number, e.g. "1440" or "-1439"
ripern commented 9 years ago

I assume you create it on "today"? I tried 10 times in a row now and always get 0 minutes, except one time when time changed to the next minute and I get 1 min. Only if I create a workout in the future I get negative values which is expected. Could you possibly create a short video of it and send me?

windmueller commented 9 years ago

While I created the video, I figured out what is wrong. I created a workout log for yesterday and finished it. 1440 minutes is exactly 24 hours. ;)

The confusing thing here is that the exercise starts yesterday with the time of today. Is this really how it is supposed to be?

Anyway, you could reformat the time, using "x hours, y minutes".

p4ker commented 9 years ago

Hi Stephan, I'm not completely sure I follow your last two comments, but at this moment it's not possible to manually enter or change the "start" and "finished" time for an exercise in a workout log (no matter if workout i done yesterday, today or tomorrow). Start time will be the time when you open the exercise and log your first set, finished time will be the time when you press the "finish exercise" button.

If we add the possibility to change or enter the start and end time for an exercise in your workout, would that solve your issue, or do you have any other ideas to share with us?

windmueller commented 9 years ago

I will try to explain what is causing this issue.

Since I am migrating from another workout app, I want to enter some old data for comparison. So what I am doing is creating workouts for old dates and entering the old exercise logs manually. Of course with this workflow all timestamps are completely useless. However, showing durations like 1440 minutes does not improve the situation. ;)

I would suggest two simple changes:

pambsoftware commented 9 years ago
  1. Changing start and end date of a workout log is already possible. Enter it and swipe left to Summary tab, click on a date, edit it and Save. It sounds like this is what you want to do. Changing start and end date for exercises is not possible today.
  2. More readable format sounds good.
windmueller commented 9 years ago

There is no need to change the start and end date for exercises in my opinion.