search

pandas-dev / pandas

Flexible and powerful data analysis / manipulation library for Python, providing labeled data structures similar to R data.frame objects, statistical functions, and much more
https://pandas.pydata.org
BSD 3-Clause "New" or "Revised" License
43.9k stars 18.03k forks source link

TST (string dtype): resolve all xfails in IO parser tests #60321

Closed jorisvandenbossche closed 1 week ago

jorisvandenbossche commented 1 week ago

There are two remaining xfails left: one related to invalid unicode (that errors if using the pyarrow-backed string dtype, so we should probably have a fall back to object dtype fo that case), and another one about specifying the names keyword with the pyarrow engine giving object-dtype columns.

xref https://github.com/pandas-dev/pandas/issues/54792

lumberbot-app[bot] commented 1 week ago

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout 2.3.x
git pull

  1. Cherry pick the first parent branch of the this PR on top of the older branch:

    git cherry-pick -x -m1 ee3c18f51b393893ed6e31214c7be2f9427ce0c9

  2. You will likely have some merge/cherry-pick conflict here, fix them and commit:

git commit -am 'Backport PR #60321: TST (string dtype): resolve all xfails in IO parser tests'
  1. Push to a named branch:
git push YOURFORK 2.3.x:auto-backport-of-pr-60321-on-2.3.x
  1. Create a PR against branch 2.3.x, I would have named this PR:

"Backport PR #60321 on branch 2.3.x (TST (string dtype): resolve all xfails in IO parser tests)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the Still Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free to suggest an improvement.

WillAyd commented 1 week ago

Will backport this one too

jorisvandenbossche commented 1 week ago

Manual backport -> https://github.com/pandas-dev/pandas/pull/60330