search

pandorabox-io / pandorabox.io

Pandorabox infrastructure code
https://pandorabox.io
31 stars 4 forks source link

fancyvend crash #354

Closed thomasrudin closed 4 years ago

thomasrudin commented 4 years ago 
minetest_1           | 2019-11-10 16:55:22: ERROR[Main]: ServerError: AsyncErr: ServerThread::run Lua: Runtime error from mod '' in callback item_OnUse(): /data/world//worldmods/fancy_vend/init.lua:1503: attempt to index local 'new_settings' (a nil value)
minetest_1           | 2019-11-10 16:55:22: ERROR[Main]: stack traceback:
minetest_1           | 2019-11-10 16:55:22: ERROR[Main]:    /data/world//worldmods/fancy_vend/init.lua:1503: in function </data/world//worldmods/fancy_vend/init.lua:1493>
m
SwissalpS commented 4 years ago

seems that if you use a wand without ever having read settings it crashes minetest.

SwissalpS commented 4 years ago

suggest fixing like this: https://github.com/pandorabox-io/fancy_vend/pull/1/commits/6dbaa3869ea533de8cc67378b565062b3e55ddaa

thomasrudin commented 4 years ago

I'd like to converge/switch to one repo at some point, ChimneySwift's repo has a few additional commits that fix a few bugs too... :/

How hard are you hanging on your local commit/PR?

SwissalpS commented 4 years ago

not at all. I just offered a fix, if there is a better solution, let's take that. Agree to use an active fork.

thomasrudin commented 4 years ago

fixed by https://github.com/pandorabox-io/fancy_vend/pull/2

cleaning up the fork later :tm: