search

pandorabox-io / pandorabox.io

Pandorabox infrastructure code
https://pandorabox.io
31 stars 4 forks source link

Conflicting recipe collection #421

Open thomasrudin opened 4 years ago

thomasrudin commented 4 years ago

Those can be re-mapped in the pandorabox_custom mod:

Conflicts

Default

pkarcs

glass_stained

homedecor

Assorted

table legs and some ladder conflict too

No recipes (yet)

SwissalpS commented 4 years ago

pkarcs_doors:wood_Rdoor and pkarcs_doors:wood_Ldoor conflict with 'Apple wood planks' which is not in guide at all

thomasrudin commented 4 years ago

pkarcs_doors:wood_Rdoor and pkarcs_doors:wood_Ldoor conflict with 'Apple wood planks' which is not in guide at all

Added, thanks

6r1d commented 4 years ago

There is no recipe for homedecor:chains. Metal chains are a an unusual addition to kitchen cabinets and lamps, but were requested before in #ru chat.

OgelGames commented 4 years ago

Reported by aorus in #main: glass_stained:pane_bar_single conflicts with xpanes:trapdoor_steel_bar.

S-S-X commented 4 years ago

added exact conflicting table legs and ladder info to first comment

zbx-pandorabox commented 3 years ago

homedecor:bathroom_tiles_light vs technic:marble_bricks
same recipe 2x2 marble

tux-pandorabox commented 3 years ago

missing recipes

advtrains_platform:platform_high_concrete advtrains_platform:platform_high_tile advtrains_platform:platform_high_wall advtrains_platform:platform_high_white advtrains_platform:platform_high_white2

advtrains_platform:platform_low_concrete advtrains_platform:platform_low_tile advtrains_platform:platform_low_wall advtrains_platform:platform_low_white advtrains_platform:platform_low_white2

advtrains_platform:platform_45_concrete advtrains_platform:platform_45_tile advtrains_platform:platform_45_wall advtrains_platform:platform_45_white advtrains_platform:platform_45_white2

advtrains_platform:platform_45_low_concrete advtrains_platform:platform_45_low_tile advtrains_platform:platform_45_low_wall advtrains_platform:platform_45_low_white advtrains_platform:platform_45_low_white2

BuckarooBanzay commented 3 years ago

advtrains_platform:platform_high_concrete

I noticed those, they are custom and registred in the pandorabox_custom mod (https://github.com/pandorabox-io/pandorabox_custom/blob/master/advtrains_platform.lua)

It might have something to do with the "latest" (7 months) update of the advtrains_platformmod: https://github.com/pandorabox-io/pandorabox-mods/commit/41eb9886a9973d6d7d1b775543524e39f7f2b91c

OgelGames commented 3 years ago

It seems to be caused by advtrains (which is where the advtrains.register_platform function is) not having a dependency on dye which is used in the craft recipe.

The easiest fix is to just have pandorabox_custom depend on dye, but it probably should be fixed in advtrains, and maybe the function should actually be in advtrains_platform instead of advtrains 😕

OgelGames commented 3 years ago

The easiest fix is to just have pandorabox_custom depend on dye

Or not... I just tried it, and it doesn't fix it, so now I have no clue why the recipes don't get registered with the nodes 😕

EDIT: Found this in my minetest log:

2020-10-12 21:14:13: WARNING[Main]:  register_platform couldn't find preset node scifi_nodes:whttl
2020-10-12 21:14:13: WARNING[Main]:  register_platform couldn't find preset node scifi_nodes:metal

Seems like advtrains is loaded before scifi_nodes, but strangely those are the only two that are in the log, the other types must have something else wrong 😖 Also pandorabox_custom depends on both of those, so that shouldn't even make a difference...

EDIT 2: Those two nodes don't even exist...

OgelGames commented 3 years ago

I found the problem, minetest.register_recipe doesn't like output starting with ":", which is how these nodes are registered.

Not sure the best way to fix it at the moment, but I did fix the wrong scifi_nodes names: https://github.com/pandorabox-io/pandorabox_custom/commit/b39e1177b1acd470d40f2b23548dea3bf67da08c

BTW, did scifi_nodes:whttl and scifi_nodes:metal ever exist? I couldn't find them or any aliases for them, only these: https://github.com/D00Med/scifi_nodes/blob/master/nodes.lua#L536 https://github.com/D00Med/scifi_nodes/blob/master/nodes.lua#L514

BuckarooBanzay commented 3 years ago

BTW, did scifi_nodes:whttl and scifi_nodes:metal ever exist? I couldn't find them or any aliases for them, only these:

Interesting, those values aren't even used in anywhere: https://github.com/D00Med/scifi_nodes/blob/master/nodes.lua#L594

S-S-X commented 3 years ago

Maybe there was emergency situation and some typos slipped in... image

Sounds that could be the case here and just have to correct those names.

OgelGames commented 3 years ago 
<Huhhila> scifi_nodes:stripes2top appears to have typo in the recipe... "scifi_noedes:black" ... and some other recipes depend on that one
BuckarooBanzay commented 3 years ago

scifi_nodes:stripes2top appears to have typo in the recipe... "scifi_noedes:black" ... and some other recipes depend on that one

Fixed in https://github.com/D00Med/scifi_nodes/commit/16ff4dcdb839dcf5178d00f07e27d4bd9b56b0c5 thanks for relaying :+1:

FeXoR-o-Illuria commented 3 years ago

1) Cobblestone Stairs (moreblocks:cobble_stairs) can be crafted and cut with table saw but don't show up in the crafting guide.

2) Cobble Stair (stairs:stair_cobble) show up in the crafting guide but hovering over them gives "Cobble Stair(??)", using the crafting recipe yields moreblocks:cobble_stairs.

3) Furthermore the recipe with stairs:stair_cobble as ingredient doesn't work with moreblocks:cobble_stairs :p

S-S-X commented 3 years ago

Cobblestone Stairs (moreblocks:cobble_stairs) can be crafted and cut with table saw but don't show up in the crafting guide.

Cobble Stair (stairs:stair_cobble) show up in the crafting guide but hovering over them gives "Cobble Stair(??)", using the crafting recipe yields moreblocks:cobble_stairs.

Furthermore the recipe with stairs:stair_cobble as ingredient doesn't work with moreblocks:cobble_stairs :p

Not sure about exact situation but I think stairs:stair_cobble and moreblocks:cobble_stairs are supposed to be exactly same item (however some mods treat those as different items). Some of those were different items before but got combined / aliased somehow, I mean similar problem that were with jungle tree trunks when there were 2 types that looked like exactly same item before those got merged together.

Does this cause some problems in game or is it more about confusing descriptions in crafting guide?

FeXoR-o-Illuria commented 3 years ago

Well, it's impossible to craft stairs back into default cobble.

Otherwise it's mostly confusing that searching for "cobblestone" does yield no stairs.

Nothing tragic I guess but IMO the usefulness of the crafting guide deteriorates with the number of naming/multiple recipes (conflicting or simply duplications) issues to the point of being nearly unusable :p

OgelGames commented 3 years ago
  1. Cobblestone Stairs (moreblocks:cobble_stairs) can be crafted and cut with table saw but don't show up in the crafting guide.

That's intentional, as explained here: https://github.com/minetest-mods/moreblocks/blob/master/settingtypes.txt

It would be nice to be able to see some in the craft guide though, and it might be possible to add fake recipes to the craft guide to show the circular saw recipes without flooding the craft guide. (maybe a "Material Slab/Stair/Slope" for each material?)

  1. Cobble Stair (stairs:stair_cobble) show up in the crafting guide but hovering over them gives "Cobble Stair(??)", using the crafting recipe yields moreblocks:cobble_stairs.

I think it actually does yield stairs:stair_cobble, but it just shows in the inventory as moreblocks:cobble_stairs. (you could check using a mithril chest)

  1. Furthermore the recipe with stairs:stair_cobble as ingredient doesn't work with moreblocks:cobble_stairs :p

Not sure why that would be, I thought recipes worked with aliased items... could be fixed though by changing recipes though.

Aliases are weird... :/

OgelGames commented 2 years ago

Used some code to check for conflicting recipes, and found these:

Wanted Item Recipe Result
homedecor:cobweb_corner mobs:cobweb
homedecor:table_legs_wood ropes:ladder_wood
xpanes:trapdoor_steel_bar glass_stained:pane_bar_single
pkarcs_doors:acacia_wood_Ldoor moreblocks:panel_acacia_wood
pkarcs_doors:acacia_wood_Rdoor moreblocks:panel_acacia_wood
pkarcs_doors:aspen_wood_Ldoor moreblocks:panel_aspen_wood
pkarcs_doors:aspen_wood_Rdoor moreblocks:panel_aspen_wood
pkarcs_doors:bronze_Ldoor moreblocks:panel_bronzeblock
pkarcs_doors:bronze_Rdoor moreblocks:panel_bronzeblock
pkarcs_doors:copper_Ldoor moreblocks:panel_copperblock
pkarcs_doors:copper_Rdoor moreblocks:panel_copperblock
pkarcs_doors:junglewood_Ldoor moreblocks:panel_junglewood
pkarcs_doors:junglewood_Rdoor moreblocks:panel_junglewood
pkarcs_doors:pine_wood_Ldoor moreblocks:panel_pine_wood
pkarcs_doors:pine_wood_Rdoor moreblocks:panel_pine_wood
pkarcs_doors:steel_Ldoor moreblocks:panel_steelblock
pkarcs_doors:steel_Rdoor moreblocks:panel_steelblock
pkarcs_doors:tin_Ldoor moreblocks:panel_tinblock
pkarcs_doors:tin_Rdoor moreblocks:panel_tinblock
pkarcs_doors:wood_Ldoor moreblocks:panel_wood
pkarcs_doors:wood_Rdoor moreblocks:panel_wood

The first three will be fixed by https://github.com/pandorabox-io/pandorabox_custom/commit/825b8bf934851cc7179d1a1ed7e05f66d171a596 and https://github.com/v-rob/glass_stained/pull/1, but I'm not sure of the best way to fix the pkarcs door recipes... 🤔