search

pandorabox-io / pandorabox.io

Pandorabox infrastructure code
https://pandorabox.io
31 stars 4 forks source link

Light on Mars #606

Open Emil9736 opened 3 years ago

Emil9736 commented 3 years ago

Command /mars_lightup dosen`t work properly. Using different types of light source has no effect. screenshot_20210116_191952 screenshot_20210116_191834 screenshot_20210116_191852 screenshot_20210116_191922 screenshot_20210116_191946

6r1d commented 3 years ago

I watched the testing process. mars_lightup created a bunch of airlight nodes, then after a second or two those started disappearig very fast, as a single entity, not as independent nodes. For the context, Eula's place is close to the world border and that may or may not influence things.

For the context, I recommended adding more light to check if it'll influence current version of mars_lightup and it didn't.

OgelGames commented 3 years ago

AFAIK, the way the current version is supposed to work is to place a column of airlights, and then let it spread by ABM to fill in the spaces.

There must be another ABM that is fighting against it, and winning, but the only likely one I could find was this one, which only replaces airlights near soil: https://github.com/pandorabox-io/planet_mars/blob/master/light_restore.lua#L31-L41

SwissalpS commented 3 years ago

currently disabled recalculation here

stopped placing airlights after this commit, only sets light value

currently relies on abm to place airlights.

Emil9736 commented 3 years ago

Problem continue stay actual. Command /mars_lightup have temporary effect. After few seconds light is going out. screenshot_20210117_215607 screenshot_20210117_215617 screenshot_20210117_215548

BuckarooBanzay commented 3 years ago

@Emil9736 what are doing there exactly? Some trees can reset the light-up effect, or are you just cycling dirt?

Emil9736 commented 3 years ago

@Emil9736 what are doing there exactly? Some trees can reset the light-up effect, or are you just cycling dirt?

BuckarooBanzay, Yes. I`m cycling dirt. There are no trees there.

SwissalpS commented 1 year ago

is the problem still occuring?

somewhat related: https://github.com/pandorabox-io/planet_mars/commit/20f7465eb56ab025f29a24a8407247a0ff9aa1d2