search

pandorabox-io / pandorabox.io

Pandorabox infrastructure code
https://pandorabox.io
31 stars 4 forks source link

geocache mod #88

Closed thomasrudin closed 5 years ago

thomasrudin commented 5 years ago

https://github.com/joshuamars/minetest-mod-geocache

thomasrudin commented 5 years ago

does not work :(

Parasitoid commented 5 years ago

Hi Thomas!

I found that there is an unnecessary concatenation operator at the end of mixed string on a line 15. After removing those two dots this mod was loaded without any problems and I could place geo block (and that also makes "singleplayer" was added as a first sign on a list). Also a chat message was displayed any time I try to manipulate that geo block ("You already signed this..."). And that was all what I could do in singleplayer (0.4.17.1). What was wrong in your test? You wrote that this does not work. Did you tested this on server and something was wrong with other players actions?

thomasrudin commented 5 years ago

Fixed mod: https://github.com/pandorabox-io/geocache Thx for reminding me :smile:

thomasrudin commented 5 years ago

Opened a PR, hope it gets merged :P https://github.com/joshuamars/minetest-mod-geocache/pull/2