cisaacstern
commented
2 years ago @sharkinsspatial, it looks like
and
are why the tests are failing, because presumably that repo and/or branch of fsspec no longer exists. Should we:
- Just remove these two image directories from this repo?
- Figure out what released version of
fsspecthey are compatible with, and make a separate PR to fix that? - Not bother fixing this in any way, maybe just merge with the failing test, because we're going to work on the automated release refactor soon anyway?
- Something else
?
sharkinsspatial
What I am changing
The
0.6.1image did not declare explicit versions for fsspec, gcsfs, and s3fs. As a result, it ended up with incompatible versions offsspecandgcsfs, resulting in failed GCS writes discovered via https://github.com/pangeo-forge/pangeo-forge-gcs-bakery/issues/19.As noted in https://github.com/pangeo-forge/pangeo-forge-recipes/pull/247, pangeo-forge-recipes
0.6.1does not work with fsspec> 2021.11.0. To get a compatible complement of fsspec + gcsfs + s3fs, I have therefore pinned all three of these packages to2021.11.0.How I did it
Declared explicit versions for these packages in this image's requirements.txt.
How you can test it
This was blocking https://github.com/pangeo-forge/pangeo-forge-gcs-bakery/issues/19, and the original image was non-functional for interface with GCS, so I've already pushed this update to Docker Hub. Once we have more services relying on these images, it will probably be best to define some approval/testing process before updating them, but in this case, I just went for it. Hopefully this did not impact any one else's work.