search

panoptyk / panoptyk-engine

5 stars 1 forks source link

Internal demo fixes #40

Closed scm2217 closed 4 years ago

scm2217 commented 4 years ago

All server items for Internal Demo. I recommend a complete refactor of Trade when possible. As well as changing https://github.com/panoptyk/panoptyk-engine/blob/c90667732e8430389633ca41eb3139a56eca57bb/src/models/idObject.ts#L139 to public serialize(agent?: Agent): any { so that private data can be customized for the receiving agent within the serialization function.

mitchkm commented 4 years ago

Should the default value of removePrivateData be true instead of false? since there are more instances where it needs to be true then false or does it not bother you in terms of coding?

scm2217 commented 4 years ago

Should the default value of removePrivateData be true instead of false? since there are more instances where it needs to be true then false or does it not bother you in terms of coding?

I think false is better since we use it for saving models, especially since a specified agent should be provided if private data is going to be removed for that client.