search

panorama-ed / maximize-select2-height

Let your Select2 dropdowns take advantage of the space on the page.
52 stars 20 forks source link

Now it working without Uniq ID attribute on select elements #15

Open dirmax opened 6 years ago

JacobEvelyn commented 6 years ago

Thanks so much for the PR, @dirmax! @parkerfinch will take a look at this tomorrow and we'll try to get it merged quickly!

parkerfinch commented 6 years ago

Thanks for submitting this @dirmax! We ran into a couple issues testing this out, which I think are because the .select2-results__options element can be added outside of the $(el).parent(). I added some more test cases in #16 today and when I tested out the code change here it didn't apply the maximization correctly.

Can you pull the new test.html file and make sure that your changes work as expected? I'm sorry we don't have a better way to test things out here; right now the best approach we have is to replace the script in that file with the new version and make sure the page still behaves as expected. Does that make sense, and is there anything else I can do to help you test out changes?

nagyimre1980 commented 1 year ago

?