search

panorama-ed / maximize-select2-height

Let your Select2 dropdowns take advantage of the space on the page.
52 stars 20 forks source link

3.5.1 Support #3

Closed ThisThatBC closed 8 years ago

ThisThatBC commented 9 years ago

Any chance getting this working for v3.5.1?

Thanks

JacobEvelyn commented 9 years ago

Great question! I think @honigc was interested in looking into that?

elmart commented 9 years ago

I have to suppose then that 4.0.x is not supported, either? Would be nice if you advertised on home page which Select2 versions are supported. Thx anyway

JacobEvelyn commented 9 years ago

@elmart great question; this is actually only written for Select2 v4. I'll change that on the README; thanks for the suggestion.

elmart commented 9 years ago

Great. Thanks :+1:

JacobEvelyn commented 8 years ago

@Uptown76 as we don't use earlier versions of Select2 for our applications and @honigc hasn't gotten a chance to look into this, I suspect we won't ourselves work to support any pre-4.0.0 versions of Select2, though we'd definitely welcome pull requests to add support for other versions.

I'm closing this for now, but do feel free to submit a pull request to add this functionality!