panter / vue-i18next

Internationalization for vue using the i18next i18n ecosystem.
https://panter.github.io/vue-i18next/
176 stars 47 forks source link

fix "cannot redefine property $i18n" #66

Open JoelPintoRibeiro opened 5 years ago

JoelPintoRibeiro commented 5 years ago

solves #65

When we have two Vue instance that uses vue-i18next in both we have a "cannot redefine property $i18n" error.

With this fix we check before the existence of this property .

It's the same fix as the vue-i18n original repo https://github.com/kazupon/vue-i18n/issues/421

Before :

image

After :

image

coveralls commented 5 years ago

Coverage Status

Coverage decreased (-0.3%) to 99.32% when pulling ccfff2d7c65d1e1de90ab4c507b79c9e4800f580 on JoelPintoRibeiro:fix/property_i18n into 6c4fac704b02e16cdf93c0d59d1a6c6a2fe308af on panter:master.