search

panter / vue-i18next

Internationalization for vue using the i18next i18n ecosystem.
https://panter.github.io/vue-i18next/
176 stars 47 forks source link

Fix window check #7

Closed menthol closed 7 years ago

menthol commented 7 years ago

typeof return always a not null string value. typeof window can return "undefined".

(!! typeof window) === true

(Fix vue-i18next in nuxtjs)

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 98.333% when pulling 0ae2c548b7b092fd7234d5aa815f1ea6f35f1a3c on menthol:patch-1 into ec869a5b56b3dccb7ceeb05be8025b68d2bc1c41 on panter:master.

claudiocro commented 7 years ago

Thank you very much!

In this project we use semantic-release. Can you rephrase your commit message to fix: window check?

FYI: commit message format

Thx!

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 98.333% when pulling 4d98440ebbbbbacb458b34e9bcc3dea58b9f0d20 on menthol:patch-1 into ec869a5b56b3dccb7ceeb05be8025b68d2bc1c41 on panter:master.

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 98.333% when pulling 85ecda7428c87894758796fe85776e5bd68cbdb2 on menthol:patch-1 into ec869a5b56b3dccb7ceeb05be8025b68d2bc1c41 on panter:master.