search

pantheon-systems / pantheon_domain_masking

Domain Masking helper module for D8
GNU General Public License v2.0
11 stars 6 forks source link

Change permissions for the configuration routes #10

Closed jrearick-pfg closed 2 years ago

jrearick-pfg commented 3 years ago

The routes for the configuration pages use the permission access administration pages. There's a lot of sites out there that grant this permission to roles that maybe shouldn't have the ability to alter these settings. Perhaps it's more appropriate to use administer site configuration which has the extra warning to only give to trusted roles?

kpaxman commented 3 years ago

1000x this! We just had someone break their site because they figured out how to access this and thought they'd see what happens.

If I can figure it out, a pull request is incoming with this change (another advantage to this being on drupal.org would be that I can use the workflow I'm most familiar with :))

kpaxman commented 3 years ago

I feel fairly certain I did that wrong, but at least there's something to look at :)

lkmorlan commented 2 years ago

The patch is fine. It is just that the merge request is against the fork instead of the original.

jspellman814 commented 2 years ago

Closing issue as the associated PR (#23) has been merged.

namespacebrian commented 2 years ago

As some people who had permissions before will no longer have them after this update, if the change ends up bothering anyone, I'll just point at everyone in this ticket ;)

Gates Ballmer

jrearick-pfg commented 2 years ago

I guess that would be all my fault 😬 /sarcasm

jrearick-pfg commented 2 years ago

Any word on when this would hit packagist? Will there need to be a "release"?

jspellman814 commented 2 years ago

@jrearick-pfg I've created a new tag, 1.0.1, which should be available through packagist shortly.

jrearick-pfg commented 2 years ago

Thanks for the bump, but I'm not seeing 1.0.1 out there yet https://packagist.org/packages/pantheon-systems/pantheon_domain_masking

jspellman814 commented 2 years ago

@jrearick-pfg Apologies for the delay - it's available now: https://packagist.org/packages/pantheon-systems/pantheon_domain_masking#1.0.1