pantheon-systems / terminus-installer

Installer for Pantheon Terminus
MIT License
7 stars 6 forks source link

Terminus 1.0 beta install fails if /usr/loca/bin/terminus present #16

Open ari-gold opened 7 years ago

ari-gold commented 7 years ago

If your issue is being submitted to report a bug, please also include the following:

  1. The name and version of your OS OSX 10.12.1
  2. The name and version of your terminal client terminal
  3. Which version of PHP you are using - you must be running 5.5.9 or later PHP 5.6.25
  4. All relevant Terminal text, including the command and its output(s)
$ curl -O https://raw.githubusercontent.com/pantheon-systems/terminus-installer/master/builds/installer.phar && php installer.phar install
<snip>
Writing lock file
Generating autoload files

  [Symfony\Component\Filesystem\Exception\IOException]                                                                                                          
  Failed to create symbolic link from "/Users/ari/vendor/bin/terminus" to "/usr/local/bin/terminus".  

install [--bin-dir [BIN-DIR]] [--install-dir [INSTALL-DIR]] [--install-version [INSTALL-VERSION]]

Suggested resolution: automatically overwrite/remove /usr/local/bin/terminus as part of installer

TeslaDethray commented 7 years ago

I do not think it is wise to remove people's bin files for them. The installer already checks to see whether the file in question is writable, and if it is not, will tell you to make a symlink or add the terminus bin dir to your path.