search

pantheon-systems / terminus-site-clone-plugin

A Terminus plugin that adds the `site:clone` command to facilitate cloning sites on Pantheon
MIT License
21 stars 11 forks source link

Remove temp directory after code clone #6

Closed ataylorme closed 6 years ago

ataylorme commented 6 years ago

Keeping it around should be optional.

ataylorme commented 6 years ago

I forgot how touch removing non-empty directories in PHP is, especially hidden directories like .git. I can use passthru and rm -rf easily but that would not support Windows. However, there is a Dockerfile that could be used for Windows.

@stevector thoughts on explicitly not supporting Windows?

stevector commented 6 years ago

I think it would make sense to use whatever pattern/directories are used by the Build Tools plugin in its local copies of sites.

ataylorme commented 6 years ago

Good call. Symfony Filesystem worked wonders.