search

pantheon-systems / terminus

The Pantheon CLI — a standalone utility for performing operations on the Pantheon Platform
https://pantheon.io
Other
318 stars 196 forks source link

On Integrated Composer/Drupal 9 sites, running "upstream:updates:apply" returns 404 error #2151

Open dficker opened 3 years ago

dficker commented 3 years ago

Expected behavior

When running Terminus 2.4.1 or below on a site using Drupal 9/Integrated Comopser, this command works:

terminus upstream:updates:apply ficker-d9-ic-test6.dev
 [warning] There are no available updates for this site.

Actual behavior

Once upgraded to Terminus 2.5.0 or 2.6.0, the same command fails:

terminus upstream:updates:apply ficker-d9-ic-test6.dev
 [error]  Client error: `GET https://terminus.pantheon.io/api/sites/5353f53c-e878-4167-bae5-5489cd7bb709/environments/dev/build/updates` resulted in a `404 Not Found` response

On these newer versions of Terminus, it does not fail on sites, such as my old D7 site:

terminus upstream:updates:apply ficker-da-blog-7.dev
 [warning] There are no available updates for this site.

Steps to reproduce the behavior

You should be able to reproduce this on any Drupal 9 and/or Integrated Composer site (I didn't have a Drupal 9 site not using Integrated Composer to test on to see which one breaks this.)

Here's my Terminus local setup, although another Pantheon customer listed the same issue in a ticket, so I don't think it's my setup which is causing the issue:

terminus self:info
 ------------------------- -------------------------------------------------------------
  PHP binary                /usr/bin/php
  PHP version               7.3.11
  php.ini used
  Terminus project config
  Terminus root dir         /Users/danielficker/terminus
  Terminus version          2.6.0
  Operating system          Darwin Kernel Version 19.6.0: Thu May  6 00:48:39 PDT 2021;
                            root:xnu-6153.141.33~1/RELEASE_X86_64
 ------------------------- -------------------------------------------------------------
stovak commented 3 years ago

Prioritized for fix in v3.0. Currently no plant to back port to 2.x once fixed.

joeparsons commented 3 years ago

Prioritized for fix in v3.0. Currently no plant to back port to 2.x once fixed.

@stovak Wasn't support for IC sites added to upstream:updates:apply in 2.x starting in 2.5.0 (with #2089)? Seems like it's just broken currently?