search

panther-hq / basket

MIT License
0 stars 0 forks source link

Functional expansion #3

Open dgavrilenko opened 4 years ago

dgavrilenko commented 4 years ago

please add the ability to insert the product description and configuration into an array for conversion to json.

For SPA (example Laravel) $basket = $this->basket->findAll(); return response()->json($basket);

will return a set of empty keys.

and please add a new tag, actual with the master

remove FINAL in class?

panther-hq commented 4 years ago

I added JsonSerializable on the Item object and Attribute object on https://www.php.net/manual/en/jsonserializable.jsonserialize.php

I added the product description to the attributes because this place is for additional things.

Why should I delete the final?