paperos-labs / feedback

Just a bug and ideas board
0 stars 0 forks source link

Mislabeling of documents in the Documents view. #237

Closed danielandelin closed 2 years ago

danielandelin commented 2 years ago

https://app.savvi.legal/c/419/documents

Not sure where all this is happening. Found this example on Savvi Technologies, Inc.

SAFEs are being called Employment Offer Letters. image

wmerfalen commented 2 years ago

@danielandelin it looks like the Question Label is being used for that label The attached photo isn't the exact account, but it has the same label and shows where the label is coming from Screen Shot 2022-05-24 at 11 14 54 AM

danielandelin commented 2 years ago

The feature type id that should be being used on those documents is 740

SHRoberts91 commented 2 years ago

So I pushed a fix that will correctly show the label for most of these, the main thing here is that that template label used in the documents section is being pulled from flat_features or the template_variant, and some of these documents are for whatever reason being connected to an incorrect template variant. I adjusted the logic to show the label from flat_features before template_type so they'll stop using that incorrect label.

We will have to look more into all the items in document_history that have a panda_template_id of NWGMkzt4R6oH6KP2ibbfgn

SHRoberts91 commented 2 years ago

And it looks like there was a dev template_variant item with the same panda_template_id as the real one, and this was causing the dev one to be pulled by that endpoint, I changed the panda_template_id on the dev one and it is no longer doing this 👌