papi-web-org / papi-web

Papi-web
7 stars 3 forks source link

Fix typos and inconsistencies in docs files #21

Closed adrienave closed 6 months ago

adrienave commented 7 months ago

This PR addresses a few typos/errors I found while reading the docs for the first time, as I wanted to understand better how this application is working.

Please check carefully my changes because I might have overlooked some details/done some mistakes, since I didn't use this application on a real scale yet.

I also take the opportunity to list some suggestions for amelioration, don't hesitate to tell me if I should convert them to a single issue, a bunch of issues or even fix some in this PR.

PS: These are just some neat pickings, it's truly amazing you built such a dense, clean and easy to follow documentation, lots of softwares should take example on this, thank you!

Amaras commented 6 months ago

Hi, thanks for the PR, I'll try to review it as soon as possible, but probably not until Monday 19.

As for the points you've made:

Since they're all documentation-related, I think you should open only one issue with different tasks.

Thanks again for the PR, feel free to contribute to the code if you want to do so :)

adrienave commented 6 months ago

You can probably correct the style inconsistency in papi-web.ini in this PR;

I don't think I can ; I'm talking about the default configuration provided as part of the latest build version (https://github.com/papi-web-org/papi-web/releases/tag/2.1.6). I can't find any occurrence of either papi-web.ini or host: 0.0.0.0 in the project that would be related to the generation of this file, I believe it's some manual action done at release time.

[...] you'd see the warnings in the logs [...]

I didn't see any in the dedicated page in the web application, but maybe it is present in the terminal logs? Or maybe my logging level is wrong.

I think we could add descriptive names in addition to 1, 2 and 3, I don't think we're ready to deprecate yet… This should be an issue;

Right, how did I forget about backward compatibility...

So sure, I will open an issue for all these points!

Thanks again for the PR, feel free to contribute to the code if you want to do so :)

That's what I'm considering yes, but I didn't start investigating the code yet.