search

paquettg / leaguewrap

League of Legend API wrapper
MIT License
67 stars 28 forks source link

Fixes #45 #46

Closed stu177 closed 10 years ago

stu177 commented 10 years ago

This allows the $data parameter on setUpParams() to accept Arrays if an Array is passed to it, allowing multiple additional fields to be declared when making a request.

I've created a test which I think so be right however I can't get it to run locally, getting an NoMatchingExpectationException error from Mockery.

coveralls commented 10 years ago

Coverage Status

Coverage decreased (-0.07%) when pulling ced571b42eca033232c07b00d4e201c22b49ec52 on stu177:master into b64fa539114f23bb18ead7bdc8a06383e44e781f on paquettg:master.

dnlbauer commented 10 years ago

Looks great. I'll check it out when I'm back home and merge it

dnlbauer commented 10 years ago

I think the error comes from line 124 in the test. You expect to get 'string1, string2' but implode to 'string1,string2' (no whitespace).

dnlbauer commented 10 years ago

Fixed your test and added to additional ones specific to setUpParams. merged! :+1:

stu177 commented 10 years ago

Ah doh. Good spot. Awesome, glad I could help!

Edit: Also something I noticed, is it worth having a .gitignore for things like the vendor folder and OS files etc?