paradigmnomad / PPJA

PPJA Stands for Project Populate Json Assets, this serves as the official github for PPJA packs.
37 stars 57 forks source link

Excessive Nesting in Harvested Drops for DGA Fresh Meat #371

Open scriptsforweirdos opened 1 year ago

scriptsforweirdos commented 1 year ago

Looking at [PPJA] Fresh Meat/[DGA] Fresh Meat/crops.json.

I'm seeing what appears to be excessive nesting in the HarvestedDrops Params.

Example:

"HarvestedDrops": [
     {
    "MaximumHarvestedQuantity": 2,
    "ExtraQuantityChance": 0.1,
    "Item": [
            {
                "Weight": 1.0,
                "Value": {
                    "Value": "ppja.freshmeat.DGA/Alpaca Meat"
                }
            },
            {
                "MinimumHarvestedQuantity": 1,
                "MaximumHarvestedQuantity": 1,
                "ExtraChance": 0.1,
                "Item": [
                    {
                        "Weight": 1,
                        "Value": null
                    },
                    {
                        "Weight": 1,
                        "Value": {
                            "Value": "ppja.freshmeat.DGA/Alpaca Fell",
                        }
                    },
                ]
            }
        ]
    }
 ],

Should probably instead be:

"HarvestedDrops": [
    {
        "MaximumHarvestedQuantity": 2,
        "ExtraQuantityChance": 0.1,
        "Item": [
                    {
                        "Weight": 1.0,
                        "Value": {
                            "Value": "ppja.freshmeat.DGA/Alpaca Meat"
                        }
                    },
                ]
    },
    {
        "MinimumHarvestedQuantity": 1,
        "MaximumHarvestedQuantity": 1,
        "ExtraChance": 0.1,
        "Item": [
            {
                "Weight": 1,
                "Value": null
            },
            {
                "Weight": 1,
                "Value": {
                    "Value": "ppja.freshmeat.DGA/Alpaca Fell",
                }
            },
        ]
    }
],

Also I suspect "ExtraChance" in the doubly-nested node should be "ExtraQuantityChance" but the converter didn't run deep enough to catch the string conversion.