search

paradoxxxzero / gnome-shell-system-monitor-applet

Display system informations in gnome shell status bar, such as memory usage, cpu usage, network rates…
GNU General Public License v3.0
1.75k stars 324 forks source link

Support GNOME 41 #717

Closed marxin closed 3 years ago

marxin commented 3 years ago

After updating to Gnome 41, I see the following error: Gtk.VBox is not a constructor. Which is likely related to fack that VBox is deprecated: https://docs.gtk.org/gtk3/class.VBox.html

marxin commented 3 years ago

The error is strange as it's guarded in if (shellMajorVersion < 40) {

https://github.com/paradoxxxzero/gnome-shell-system-monitor-applet/blob/133f9f32bca5d159515d709bbdee81bf497ebdc5/system-monitor%40paradoxxx.zero.gmail.com/prefs.js#L144-L151

marxin commented 3 years ago

Oh, so one only needs adding 41 to shell-version.

rastersoft commented 3 years ago

I added "41" to metadata.json in Debian Sid (with Gnome Shell 41) and this works fine. Please, merge #718.

freddyw commented 3 years ago

Fedora 35 was released today so I would like this merged as well.