paraglider-project / paraglider

Streamlining cloud networking
https://paragliderproject.io
Apache License 2.0
61 stars 4 forks source link

Fix linter errors in azure package #379

Open praveingk opened 5 months ago

praveingk commented 5 months ago

Steps to reproduce: 1) Replace .golangci.yml to this version 2) Run golangci-lint run --config=./.golangci.yaml ./pkg/azure/...

pkg/azure/naming.go:38:6: var-naming: func getVnetFromSubnetId should be getVnetFromSubnetID (revive)
pkg/azure/naming.go:49: line is 204 characters (lll)
pkg/azure/naming.go:53: line is 172 characters (lll)
pkg/azure/naming.go:90:1: paramTypeCombine: func(location string, namespace string) string could be replaced with func(location, namespace string) string (gocritic)
pkg/azure/naming.go:106:1: paramTypeCombine: func(namespace string, cloud string, idx int) string could be replaced with func(namespace, cloud string, idx int) string (gocritic)
pkg/azure/naming.go:110:1: paramTypeCombine: func(namespace string, cloud string, idx int) string could be replaced with func(namespace, cloud string, idx int) string (gocritic)
pkg/azure/plugin.go:50:47: var-naming: method parameter resourceIdInfo should be resourceIDInfo (revive)
pkg/azure/plugin.go:70: line is 149 characters (lll)
pkg/azure/plugin.go:71:2: var-naming: var resourceId should be resourceID (revive)
pkg/azure/plugin.go:72:2: var-naming: var resourceIdInfo should be resourceIDInfo (revive)
pkg/azure/plugin.go:107: line is 133 characters (lll)
pkg/azure/plugin.go:109: line is 164 characters (lll)
pkg/azure/plugin.go:111:2: var-naming: var resourceIdInfo should be resourceIDInfo (revive)
pkg/azure/plugin.go:126:29: var-declaration: should omit type map[string]int32 from declaration of var existingRulePriorities; it will be inferred from the right-hand side (revive)
pkg/azure/plugin.go:127:32: var-declaration: should omit type map[int32]bool from declaration of var reservedPrioritiesInbound; it will be inferred from the right-hand side (revive)
pkg/azure/plugin.go:128:33: var-declaration: should omit type map[int32]bool from declaration of var reservedPrioritiesOutbound; it will be inferred from the right-hand side (revive)
pkg/azure/plugin.go:144:74: Non-inherited new context, use function like `context.WithXXX` instead (contextcheck)
pkg/azure/plugin.go:169:7: variable name 'i' is too short for the scope of its usage (varnamelen)
pkg/azure/plugin.go:173:4: `if peeringCloudInfo.Cloud != utils.AZURE` has complex nested blocks (complexity: 6) (nestif)
pkg/azure/plugin.go:197: line is 136 characters (lll)
pkg/azure/plugin.go:219: line is 138 characters (lll)
pkg/azure/plugin.go:231: line is 171 characters (lll)
pkg/azure/plugin.go:233:2: var-naming: var resourceIdInfo should be resourceIDInfo (revive)
pkg/azure/plugin.go:263: line is 161 characters (lll)
pkg/azure/plugin.go:270:2: var-naming: var resourceIdInfo should be resourceIDInfo (revive)
pkg/azure/plugin.go:282: line is 157 characters (lll)
pkg/azure/plugin.go:301: line is 185 characters (lll)
pkg/azure/plugin.go:319: line is 187 characters (lll)
pkg/azure/plugin.go:357: line is 134 characters (lll)
pkg/azure/plugin.go:366: line is 187 characters (lll)
pkg/azure/plugin.go:368: line is 137 characters (lll)
pkg/azure/plugin.go:383:2: `if !peeringExists` has complex nested blocks (complexity: 10) (nestif)
pkg/azure/plugin.go:409: line is 170 characters (lll)
pkg/azure/plugin.go:412:6: variable name 'i' is too short for the scope of its usage (varnamelen)
pkg/azure/plugin.go:417:3: var-naming: var resourceIdInfo should be resourceIDInfo (revive)
pkg/azure/plugin.go:443: line is 143 characters (lll)
pkg/azure/plugin.go:446:3: var-naming: var resourceIdInfo should be resourceIDInfo (revive)
pkg/azure/plugin.go:461:11: superfluous-else: if block ends with a continue statement, so drop this else and outdent its block (revive)
pkg/azure/plugin.go:470: line is 194 characters (lll)
pkg/azure/plugin.go:473:3: var-naming: var resourceIdInfo should be resourceIDInfo (revive)
pkg/azure/plugin.go:488:11: superfluous-else: if block ends with a continue statement, so drop this else and outdent its block (revive)
pkg/azure/plugin.go:499: line is 158 characters (lll)
pkg/azure/plugin.go:500:2: var-naming: var resourceId should be resourceID (revive)
pkg/azure/plugin.go:502:2: var-naming: var resourceIdInfo should be resourceIDInfo (revive)
pkg/azure/plugin.go:516:2: `if err != nil` has complex nested blocks (complexity: 33) (nestif)
pkg/azure/plugin.go:589: line is 140 characters (lll)
pkg/azure/plugin.go:590: line is 188 characters (lll)
pkg/azure/plugin.go:605: line is 145 characters (lll)
pkg/azure/plugin.go:611: line is 141 characters (lll)
pkg/azure/plugin.go:634: line is 132 characters (lll)
pkg/azure/plugin.go:638: line is 145 characters (lll)
pkg/azure/plugin.go:650:4: var-naming: var publicIPAddressIdInfo should be publicIPAddressIDInfo (revive)
pkg/azure/plugin.go:670: line is 170 characters (lll)
pkg/azure/plugin.go:671:2: var-naming: var resourceIdInfo should be resourceIDInfo (revive)
pkg/azure/plugin.go:682:6: variable name 'i' is too short for the scope of its usage (varnamelen)
pkg/azure/plugin.go:740: line is 150 characters (lll)
pkg/azure/plugin.go:754:64: hugeParam: azureHandler is heavy (192 bytes); consider passing it by pointer (gocritic)
pkg/azure/plugin.go:763: line is 137 characters (lll)
pkg/azure/plugin.go:778: line is 173 characters (lll)
pkg/azure/plugin.go:782: line is 161 characters (lll)
pkg/azure/plugin.go:795:53: unexported-return: exported func Setup returns unexported type *azure.azurePluginServer, which can be annoying to use (revive)
pkg/azure/priority_utils.go:25: line is 137 characters (lll)
pkg/azure/priority_utils.go:27: line is 132 characters (lll)
pkg/azure/priority_utils.go:28:1: paramTypeCombine: func(reservedPrioritiesInbound map[int32]bool, reservedPrioritiesOutbound map[int32]bool, existingRulePriorities map[string]int32, nsg *armnetwork.SecurityGroup) error could be replaced with func(reservedPrioritiesInbound, reservedPrioritiesOutbound map[int32]bool, existingRulePriorities map[string]int32, nsg *armnetwork.SecurityGroup) error (gocritic)
pkg/azure/priority_utils.go:47:1: paramTypeCombine: func(reservedPriorities map[int32]bool, start int32, end int32) int32 could be replaced with func(reservedPriorities map[int32]bool, start, end int32) int32 (gocritic)
pkg/azure/resources.go:50:1: paramTypeCombine: func(subscriptionId string, resourceGroupName string, vmName string) string could be replaced with func(subscriptionId, resourceGroupName, vmName string) string (gocritic)
pkg/azure/resources.go:51: line is 141 characters (lll)
pkg/azure/resources.go:54:1: paramTypeCombine: func(subscriptionId string, resourceGroupName string, clusterName string) string could be replaced with func(subscriptionId, resourceGroupName, clusterName string) string (gocritic)
pkg/azure/resources.go:55: line is 146 characters (lll)
pkg/azure/resources.go:58:6: var-naming: func getDnsServiceCidr should be getDNSServiceCidr (revive)
pkg/azure/resources.go:66:2: ifElseChain: rewrite if-else to switch statement (gocritic)
pkg/azure/resources.go:70:9: indent-error-flow: if block ends with a return statement, so drop this else and outdent its block (revive)
pkg/azure/resources.go:87:1: paramTypeCombine: func(ctx context.Context, handler *AzureSDKHandler, resourceID string, namespace string) (*resourceNetworkInfo, error) could be replaced with func(ctx context.Context, handler *AzureSDKHandler, resourceID, namespace string) (*resourceNetworkInfo, error) (gocritic)
pkg/azure/resources.go:110:100: unexported-return: exported func GetNetworkInfoFromResource returns unexported type *azure.resourceNetworkInfo, which can be annoying to use (revive)
pkg/azure/resources.go:134:106: unexported-return: exported func GetResourceInfoFromResourceDesc returns unexported type *azure.resourceInfo, which can be annoying to use (revive)
pkg/azure/resources.go:143: line is 234 characters (lll)
pkg/azure/resources.go:152:6: exported: type name will be used as azure.AzureResourceHandler by other packages, and that stutters; consider calling this ResourceHandler (revive)
pkg/azure/resources.go:154: line is 135 characters (lll)
pkg/azure/resources.go:158: line is 228 characters (lll)
pkg/azure/resources.go:167: line is 169 characters (lll)
pkg/azure/resources.go:173:16: Error return value is not checked (errcheck)
pkg/azure/resources.go:174:11: Error return value is not checked (errcheck)
pkg/azure/resources.go:206: line is 155 characters (lll)
pkg/azure/resources.go:212:2: var-naming: var resourceDeploymentIdInfo should be resourceDeploymentIDInfo (revive)
pkg/azure/resources.go:216: line is 276 characters (lll)
pkg/azure/resources.go:220: line is 262 characters (lll)
pkg/azure/resources.go:233:1: unnamedResult: consider giving a name to these results (gocritic)
pkg/azure/resources.go:239: line is 231 characters (lll)
pkg/azure/resources.go:279:74: non-wrapping format verb for fmt.Errorf. Use `%w` to format errors (errorlint)
pkg/azure/resources.go:301: line is 156 characters (lll)
pkg/azure/resources.go:307:2: var-naming: var resourceDeploymentIdInfo should be resourceDeploymentIDInfo (revive)
pkg/azure/resources.go:311: line is 282 characters (lll)
pkg/azure/resources.go:315: line is 263 characters (lll)
pkg/azure/resources.go:328:1: unnamedResult: consider giving a name to these results (gocritic)
pkg/azure/resources.go:333: line is 170 characters (lll)
pkg/azure/resources.go:338:14: Error return value is not checked (errcheck)
pkg/azure/resources.go:339:18: Error return value is not checked (errcheck)
pkg/azure/resources.go:340:14: Error return value is not checked (errcheck)
pkg/azure/resources.go:341:41: Non-inherited new context, use function like `context.WithXXX` instead (contextcheck)
pkg/azure/resources.go:350:41: Non-inherited new context, use function like `context.WithXXX` instead (contextcheck)
pkg/azure/resources.go:366: line is 247 characters (lll)
pkg/azure/resources.go:374: line is 151 characters (lll)
pkg/azure/resources.go:386: line is 155 characters (lll)
pkg/azure/resources.go:407:74: non-wrapping format verb for fmt.Errorf. Use `%w` to format errors (errorlint)
pkg/azure/sdk_handler.go:43:6: exported: type name will be used as azure.AzureSDKHandler by other packages, and that stutters; consider calling this SDKHandler (revive)
pkg/azure/sdk_handler.go:81: line is 134 characters (lll)
pkg/azure/sdk_handler.go:154:6: exported: type name will be used as azure.AzureCredentialGetter by other packages, and that stutters; consider calling this CredentialGetter (revive)
pkg/azure/sdk_handler.go:168:1: paramTypeCombine: func(subid string, resourceGroupName string) could be replaced with func(subid, resourceGroupName string) (gocritic)
pkg/azure/sdk_handler.go:174:17: var-declaration: should omit type string from declaration of var apiVersion; it will be inferred from the right-hand side (revive)
pkg/azure/sdk_handler.go:187: line is 131 characters (lll)
pkg/azure/sdk_handler.go:197:1: paramTypeCombine: func(ctx context.Context, rule *paragliderpb.PermitListRule, nsgName string, ruleName string, resourceIpAddress string, priority int32) (*armnetwork.SecurityRule, error) could be replaced with func(ctx context.Context, rule *paragliderpb.PermitListRule, nsgName, ruleName, resourceIpAddress string, priority int32) (*armnetwork.SecurityRule, error) (gocritic)
pkg/azure/sdk_handler.go:231:66: non-wrapping format verb for fmt.Errorf. Use `%w` to format errors (errorlint)
pkg/azure/sdk_handler.go:236:91: non-wrapping format verb for fmt.Errorf. Use `%w` to format errors (errorlint)
pkg/azure/sdk_handler.go:242:1: paramTypeCombine: func(ctx context.Context, subnetID string, nsgID string) error could be replaced with func(ctx context.Context, subnetID, nsgID string) error (gocritic)
pkg/azure/sdk_handler.go:270:1: paramTypeCombine: func(ctx context.Context, nsgName string, ruleName string) error could be replaced with func(ctx context.Context, nsgName, ruleName string) error (gocritic)
pkg/azure/sdk_handler.go:310:1: paramTypeCombine: func(ctx context.Context, vnet1Name string, vnet2Name string, vnet2SubscriptionID string, vnet2ResourceGroupName string) error could be replaced with func(ctx context.Context, vnet1Name, vnet2Name, vnet2SubscriptionID, vnet2ResourceGroupName string) error (gocritic)
pkg/azure/sdk_handler.go:323: line is 133 characters (lll)
pkg/azure/sdk_handler.go:331: line is 133 characters (lll)
pkg/azure/sdk_handler.go:332:1: paramTypeCombine: func(ctx context.Context, vnet1Name string, vnet2Name string) error could be replaced with func(ctx context.Context, vnet1Name, vnet2Name string) error (gocritic)
pkg/azure/sdk_handler.go:347:1: paramTypeCombine: func(ctx context.Context, vnetName string, gatewayVnetName string, vnetToGatewayVnetPeering *armnetwork.VirtualNetworkPeering, gatewayVnetToVnetPeering *armnetwork.VirtualNetworkPeering) error could be replaced with func(ctx context.Context, vnetName, gatewayVnetName string, vnetToGatewayVnetPeering, gatewayVnetToVnetPeering *armnetwork.VirtualNetworkPeering) error (gocritic)
pkg/azure/sdk_handler.go:348: line is 141 characters (lll)
pkg/azure/sdk_handler.go:361: line is 140 characters (lll)
pkg/azure/sdk_handler.go:377: line is 132 characters (lll)
pkg/azure/sdk_handler.go:384:1: paramTypeCombine: func(ctx context.Context, virtualNetworkName string, virtualNetworkPeeringName string, parameters armnetwork.VirtualNetworkPeering) (*armnetwork.VirtualNetworkPeering, error) could be replaced with func(ctx context.Context, virtualNetworkName, virtualNetworkPeeringName string, parameters armnetwork.VirtualNetworkPeering) (*armnetwork.VirtualNetworkPeering, error) (gocritic)
pkg/azure/sdk_handler.go:385: line is 148 characters (lll)
pkg/azure/sdk_handler.go:396:1: paramTypeCombine: func(ctx context.Context, virtualNetworkName string, virtualNetworkPeeringName string) (*armnetwork.VirtualNetworkPeering, error) could be replaced with func(ctx context.Context, virtualNetworkName, virtualNetworkPeeringName string) (*armnetwork.VirtualNetworkPeering, error) (gocritic)
pkg/azure/sdk_handler.go:404: line is 147 characters (lll)
pkg/azure/sdk_handler.go:426:74: non-wrapping format verb for fmt.Errorf. Use `%w` to format errors (errorlint)
pkg/azure/sdk_handler.go:435:79: non-wrapping format verb for fmt.Errorf. Use `%w` to format errors (errorlint)
pkg/azure/sdk_handler.go:444:14: G109: Potential Integer overflow made by strconv.Atoi result conversion to int16/32 (gosec)
pkg/azure/sdk_handler.go:445:14: G109: Potential Integer overflow made by strconv.Atoi result conversion to int16/32 (gosec)
pkg/azure/sdk_handler.go:454: line is 135 characters (lll)
pkg/azure/sdk_handler.go:464:1: paramTypeCombine: func(ctx context.Context, vnetName string, location string, namespace string, orchestratorAddr string) (*armnetwork.VirtualNetwork, error) could be replaced with func(ctx context.Context, vnetName, location, namespace, orchestratorAddr string) (*armnetwork.VirtualNetwork, error) (gocritic)
pkg/azure/sdk_handler.go:466: line is 134 characters (lll)
pkg/azure/sdk_handler.go:467:2: `if err != nil` has complex nested blocks (complexity: 6) (nestif)
pkg/azure/sdk_handler.go:479:51: Non-inherited new context, use function like `context.WithXXX` instead (contextcheck)
pkg/azure/sdk_handler.go:485:10: indent-error-flow: if block ends with a return statement, so drop this else and outdent its block (revive)
pkg/azure/sdk_handler.go:495:1: paramTypeCombine: func(ctx context.Context, namespace string, vnetName string, subnetName string, orchestratorAddr string) (*armnetwork.Subnet, error) could be replaced with func(ctx context.Context, namespace, vnetName, subnetName, orchestratorAddr string) (*armnetwork.Subnet, error) (gocritic)
pkg/azure/sdk_handler.go:505:49: Non-inherited new context, use function like `context.WithXXX` instead (contextcheck)
pkg/azure/sdk_handler.go:515: line is 135 characters (lll)
pkg/azure/sdk_handler.go:532:1: paramTypeCombine: func(ctx context.Context, location string, vnetName string, addressSpace string) (*armnetwork.VirtualNetwork, error) could be replaced with func(ctx context.Context, location, vnetName, addressSpace string) (*armnetwork.VirtualNetwork, error) (gocritic)
pkg/azure/sdk_handler.go:567: line is 156 characters (lll)
pkg/azure/sdk_handler.go:588:1: paramTypeCombine: func(ctx context.Context, resourceName string, location string, allowedCIDRs map[string]string) (*armnetwork.SecurityGroup, error) could be replaced with func(ctx context.Context, resourceName, location string, allowedCIDRs map[string]string) (*armnetwork.SecurityGroup, error) (gocritic)
pkg/azure/sdk_handler.go:623:2: variable name 'i' is too short for the scope of its usage (varnamelen)
pkg/azure/sdk_handler.go:625:3: appendCombine: can combine chain of 2 appends into one (gocritic)
pkg/azure/sdk_handler.go:653: line is 140 characters (lll)
pkg/azure/sdk_handler.go:667:1: paramTypeCombine: func(ctx context.Context, subnetID string, location string, nicName string) (*armnetwork.Interface, error) could be replaced with func(ctx context.Context, subnetID, location, nicName string) (*armnetwork.Interface, error) (gocritic)
pkg/azure/sdk_handler.go:707:69: hugeParam: parameters is heavy (120 bytes); consider passing it by pointer (gocritic)
pkg/azure/sdk_handler.go:722:65: hugeParam: parameters is heavy (80 bytes); consider passing it by pointer (gocritic)
pkg/azure/sdk_handler.go:745: line is 185 characters (lll)
pkg/azure/sdk_handler.go:766:83: hugeParam: parameters is heavy (96 bytes); consider passing it by pointer (gocritic)
pkg/azure/sdk_handler.go:787:1: paramTypeCombine: func(ctx context.Context, virtualNetworkName string, subnetName string, parameters armnetwork.Subnet) (*armnetwork.Subnet, error) could be replaced with func(ctx context.Context, virtualNetworkName, subnetName string, parameters armnetwork.Subnet) (*armnetwork.Subnet, error) (gocritic)
pkg/azure/sdk_handler.go:788: line is 134 characters (lll)
pkg/azure/sdk_handler.go:799:1: paramTypeCombine: func(ctx context.Context, virtualNetworkName string, subnetName string) (*armnetwork.Subnet, error) could be replaced with func(ctx context.Context, virtualNetworkName, subnetName string) (*armnetwork.Subnet, error) (gocritic)
pkg/azure/sdk_handler.go:819: line is 171 characters (lll)
pkg/azure/sdk_handler.go:840: line is 207 characters (lll)
pkg/azure/sdk_handler.go:842: line is 133 characters (lll)
pkg/azure/sdk_handler.go:853: line is 149 characters (lll)
pkg/azure/sdk_handler.go:862:56: ptrToRefParam: consider `tags' to be of non-pointer type (gocritic)
pkg/azure/sdk_handler.go:869:1: unnamedResult: consider giving a name to these results (gocritic)
pkg/azure/sdk_handler.go:882:1: unnamedResult: consider giving a name to these results (gocritic)
pkg/azure/sdk_handler.go:946:1: paramTypeCombine: func(localVnetName string, remoteVnetName string) string could be replaced with func(localVnetName, remoteVnetName string) string (gocritic)
pkg/azure/sdk_handler.go:951:21: captLocal: `ID' should not be capitalized (gocritic)
pkg/azure/test_utils.go:43:2: var-naming: const deploymentId should be deploymentID (revive)
pkg/azure/test_utils.go:47:2: var-naming: const validNicId should be validNicID (revive)
pkg/azure/test_utils.go:52:2: var-naming: const validVnetId should be validVnetID (revive)
pkg/azure/test_utils.go:55:2: var-naming: const validPublicIpAddressName should be validPublicIPAddressName (revive)
pkg/azure/test_utils.go:56:2: var-naming: const validPublicIpAddressId should be validPublicIPAddressID (revive)
pkg/azure/test_utils.go:58: line is 140 characters (lll)
pkg/azure/test_utils.go:62:2: var-naming: const validVmName should be validVMName (revive)
pkg/azure/test_utils.go:76:14: returnAfterHttpError: Possibly return is missed after the http.Error call (gocritic)
pkg/azure/test_utils.go:81: line is 131 characters (lll)
pkg/azure/test_utils.go:82: line is 132 characters (lll)
pkg/azure/test_utils.go:84:54: parameter name 'r' is too short for the scope of its usage (varnamelen)
pkg/azure/test_utils.go:95:4: `if strings.Contains(path, "/securityRules")` has complex nested blocks (complexity: 13) (nestif)
pkg/azure/test_utils.go:96:20: "PUT" can be replaced by http.MethodPut (usestdlibvars)
pkg/azure/test_utils.go:108:27: "DELETE" can be replaced by http.MethodDelete (usestdlibvars)
pkg/azure/test_utils.go:113:20: "GET" can be replaced by http.MethodGet (usestdlibvars)
pkg/azure/test_utils.go:121:20: "PUT" can be replaced by http.MethodPut (usestdlibvars)
pkg/azure/test_utils.go:134:19: "GET" can be replaced by http.MethodGet (usestdlibvars)
pkg/azure/test_utils.go:142:19: "PUT" can be replaced by http.MethodPut (usestdlibvars)
pkg/azure/test_utils.go:154:19: "GET" can be replaced by http.MethodGet (usestdlibvars)
pkg/azure/test_utils.go:162:19: "PUT" can be replaced by http.MethodPut (usestdlibvars)
pkg/azure/test_utils.go:174:4: ifElseChain: rewrite if-else to switch statement (gocritic)
pkg/azure/test_utils.go:175:20: "GET" can be replaced by http.MethodGet (usestdlibvars)
pkg/azure/test_utils.go:183:20: "PUT" can be replaced by http.MethodPut (usestdlibvars)
pkg/azure/test_utils.go:194:20: "GET" can be replaced by http.MethodGet (usestdlibvars)
pkg/azure/test_utils.go:202:20: "PUT" can be replaced by http.MethodPut (usestdlibvars)
pkg/azure/test_utils.go:223:20: "GET" can be replaced by http.MethodGet (usestdlibvars)
pkg/azure/test_utils.go:231:20: "PUT" can be replaced by http.MethodPut (usestdlibvars)
pkg/azure/test_utils.go:244:19: "GET" can be replaced by http.MethodGet (usestdlibvars)
pkg/azure/test_utils.go:252:19: "PUT" can be replaced by http.MethodPut (usestdlibvars)
pkg/azure/test_utils.go:264:19: "GET" can be replaced by http.MethodGet (usestdlibvars)
pkg/azure/test_utils.go:272:19: "PUT" can be replaced by http.MethodPut (usestdlibvars)
pkg/azure/test_utils.go:284:19: "GET" can be replaced by http.MethodGet (usestdlibvars)
pkg/azure/test_utils.go:292:19: "PUT" can be replaced by http.MethodPut (usestdlibvars)
pkg/azure/test_utils.go:304:19: "GET" can be replaced by http.MethodGet (usestdlibvars)
pkg/azure/test_utils.go:312:19: "PUT" can be replaced by http.MethodPut (usestdlibvars)
pkg/azure/test_utils.go:324:19: "GET" can be replaced by http.MethodGet (usestdlibvars)
pkg/azure/test_utils.go:332:19: "PUT" can be replaced by http.MethodPut (usestdlibvars)
pkg/azure/test_utils.go:349:2: var-naming: struct field subId should be subID (revive)
pkg/azure/test_utils.go:365:27: unused-parameter: parameter 't' seems to be unused, consider removing or renaming it as _ (revive)
pkg/azure/test_utils.go:378:2: naked return in func `SetupFakeAzureServer` with 14 lines of code (nakedret)
pkg/azure/test_utils.go:385:6: func `getFakeInterface` is unused (unused)
pkg/azure/test_utils.go:406:6: func `getFakeNSG` is unused (unused)
pkg/azure/test_utils.go:413:6: func `getFakeSubnet` is unused (unused)
pkg/azure/test_utils.go:427:6: func `getFakeVirtualNetwork` is unused (unused)
pkg/azure/test_utils.go:446:6: func `getFakeVirtualMachine` is unused (unused)
pkg/azure/test_utils.go:465:6: func `getFakeCluster` is unused (unused)
pkg/azure/test_utils.go:489:6: func `getFakeVMGenericResource` is unused (unused)
pkg/azure/test_utils.go:505:6: func `getFakeAKSGenericResource` is unused (unused)
pkg/azure/test_utils.go:519:6: func `getFakeVMResourceDescription` is unused (unused)
pkg/azure/test_utils.go:532:6: func `getFakeClusterResourceDescription` is unused (unused)
pkg/azure/test_utils.go:545:6: func `getFakeResourceInfo` is unused (unused)
pkg/azure/utils.go:48:6: var-naming: func GetAzureSubscriptionId should be GetAzureSubscriptionID (revive)
pkg/azure/utils.go:49:2: var-naming: var subscriptionId should be subscriptionID (revive)
pkg/azure/utils.go:57:33: var-naming: func parameter subscriptionId should be subscriptionID (revive)
pkg/azure/utils.go:70:1: paramTypeCombine: func(subscriptionId string, testName string) string could be replaced with func(subscriptionId, testName string) string (gocritic)
pkg/azure/utils.go:92:1: paramTypeCombine: func(subscriptionId string, resourceGroupName string, namespace string) could be replaced with func(subscriptionId, resourceGroupName, namespace string) (gocritic)
pkg/azure/utils.go:93:2: `if os.Getenv("INVISINETS_TEST_PERSIST") != "1"` has complex nested blocks (complexity: 40) (nestif)
pkg/azure/utils.go:109: line is 168 characters (lll)
pkg/azure/utils.go:152:16: ST1005: error strings should not be capitalized (stylecheck)
pkg/azure/utils.go:160: line is 145 characters (lll)
pkg/azure/utils.go:185:14: ST1005: error strings should not be capitalized (stylecheck)
pkg/azure/utils.go:196:14: ST1005: error strings should not be capitalized (stylecheck)
pkg/azure/utils.go:205: line is 157 characters (lll)
pkg/azure/utils.go:209:59: non-wrapping format verb for fmt.Errorf. Use `%w` to format errors (errorlint)
pkg/azure/utils.go:213:59: non-wrapping format verb for fmt.Errorf. Use `%w` to format errors (errorlint)
pkg/azure/utils.go:219:6: var-naming: func GetTestVmParameters should be GetTestVMParameters (revive)
pkg/azure/utils.go:226: line is 145 characters (lll)
pkg/azure/utils.go:245:48: unexported-return: exported func InitializeServer returns unexported type *azure.azurePluginServer, which can be annoying to use (revive)
pkg/azure/utils.go:253:6: var-naming: func GetVmIpAddress should be GetVMIPAddress (revive)
pkg/azure/utils.go:254:2: var-naming: var resourceIdInfo should be resourceIDInfo (revive)
pkg/azure/utils.go:279:2: var-naming: var networkInterfaceIdSplit should be networkInterfaceIDSplit (revive)
pkg/azure/utils.go:281: line is 160 characters (lll)
pkg/azure/utils.go:289: line is 131 characters (lll)
pkg/azure/utils.go:294:71: non-wrapping format verb for fmt.Errorf. Use `%w` to format errors (errorlint)
pkg/azure/utils.go:310:1: paramTypeCombine: func(sourceVmResourceID string, destinationIPAddress string, sourceVmNamespace string) (bool, error) could be replaced with func(sourceVmResourceID, destinationIPAddress, sourceVmNamespace string) (bool, error) (gocritic)
pkg/azure/utils.go:326: line is 163 characters (lll)
pkg/azure/utils.go:344: line is 210 characters (lll)
pkg/azure/utils.go:369:2: `if os.Getenv("INVISINETS_AZURE_RESOURCE_GROUP") != ""` has complex nested blocks (complexity: 5) (nestif)
pkg/azure/utils.go:370: line is 144 characters (lll)
pkg/azure/utils.go:383: line is 214 characters (lll)
pkg/azure/utils.go:392: line is 162 characters (lll)
pkg/azure/utils.go:400: line is 186 characters (lll)
245 issues:
* contextcheck: 5
* errcheck: 5
* errorlint: 9
* gocritic: 42
* gosec: 2
* lll: 84
* nakedret: 1
* nestif: 7
* revive: 47
* stylecheck: 3
* unused: 11
* usestdlibvars: 24
* varnamelen: 5