parallaxinc / Simple-Libraries

Contents of the SimpleIDE workspace folder and its Parallax Learn Simple Libraries subfolder.
http://learn.parallax.com/propeller-c-set-simpleide/update-your-learn-folder
21 stars 20 forks source link

Simple Text Terminal Compatibility #46

Open AndyLindsay opened 8 years ago

AndyLindsay commented 8 years ago

Please make corrections in the SimpleTextTerminalCompatibility branch.

https://github.com/parallaxinc/Simple-Libraries/tree/SimpleTextTerminalCompatibility

Since this behavior and any change to it may affect many libraries (that use serial drivers), and several terminals, it's going to be important to release one comprehensive repair instead of repeatedly treating the individual symptoms. This in mind, I proposed the approach below. It's not a small project, but it should at least prevent anything from appearing to be completely broken on the next Simple Libraries release.

PropGit commented 8 years ago

I like this approach, all things considered. I think most of the modes defined by the constants will result in the same operation as TERM_NONE, but you're defining it that way to make it very clear to the user how to set it for the intention, right?