search

parallaxsw / OpenSTA

GNU General Public License v3.0
52 stars 23 forks source link

Sdc.tcl: invoke original_source if we can #76

Closed oharboe closed 3 months ago

oharboe commented 3 months ago

This preserves behaviors such as 'info script' of the original tcl implementation.

CLAassistant commented 3 months ago

CLA assistant check
All committers have signed the CLA.

oharboe commented 3 months ago

@tspyrou @maliberty FYI

jjcherry56 commented 3 months ago

This fails a large number of regressions in opensta and openroad (try rsz/test/regression for example). The issue is bindings of variables set in a sourced script don't stick.

oharboe commented 3 months ago

@jjcherry56 Thanks for the feedback. I will try again if I find an approach tht works with rsz/test/regression

jjcherry56 commented 3 months ago

I tried a few things on my end as well. I couldn't find anything.