paranext / paranext-core

Electron client, extension host, and C# library for Paranext
https://paranext.github.io/paranext-core/
MIT License
17 stars 2 forks source link

Add ability to configure `InternetSettings.xml` #1254

Closed tjcouch-sil closed 1 week ago

tjcouch-sil commented 1 month ago

User Story As a Bible translator, I want to be able to log in as my Paratext Registry user without opening Paratext 9 so that I can see available resources, use S/R, etc. without having to log in on Paratext 9.

Description In order for S/R and such to work properly using only Paratext 10, we need to add the ability to configure InternetSettings.xml.

Implementation idea Image

Image

Shift+Click Mega menu Image

InternetAccess.RawStatus InternetAccess.SetProxy InternetAccess.SelectedServers

Testing idea

  1. Temporarily remove %localappdata%/Paratext95/InternetSettings.xml and %localappdata%/Paratext95/RegistrationInfo.xml
  2. Open Paratext 10 Studio and make sure the Paratext Registration Information dialog opens automatically (it should not open automatically in Platform.Bible.)
  3. Uncheck the setting Main menu -> Settings -> Paratext Registration and Internet Settings -> Show Paratext Registration Web View on Startup (in Platform.Bible, this will be unchecked by default)
  4. Close Paratext 10 Studio and open it again. Make sure the Paratext Registration Information dialog does not open automatically
  5. Open S/R dialog and make sure it shows an error and a button to configure Paratext registration and internet settings
  6. Click the button - it should open the Paratext Registration Information dialog
  7. Set up your registry information again and set the Internet Setting Paratext Servers to Development (or whatever your usual one is). Click Save and Restart and wait for it to restart
  8. Open S/R dialog and make sure it loads projects appropriately
Sebastian-ubs commented 4 weeks ago

Make sure it is clear this is only changing internet settings for ParatextData.dll

Are we using this setting only for S/R because it is easier for now? Finally I guess the user will only want a single internet setting for whole Paratext, like in PT9.

tjcouch-sil commented 4 weeks ago

Yes, this is simply a stipulation for now. We intend to change this at some point. One setting indeed.

Sebastian-ubs commented 4 weeks ago

Right. Just in case implementing it for the whole app at once would not be much effort, I guess that would pay out, as releasing with a setting that will later be changed adds effort for migration:

Sebastian-ubs commented 3 weeks ago

Decision/info during roadmap meeting: Currently only Paratext dll related internet communication

lyonsil commented 2 weeks ago

We can add this to the bottom of the Paratext Registration UI for now because putting it where it might belong long-term (i.e., the settings UI) would be problematic for now. This should not stay in this dialog forever.

tjcouch-sil commented 1 week ago

PRs: Added internet settings to Paratext registration info form, fixed disabling internet in sensitive locations - 1 unreplied - Reviewable Simplified path to filling out Paratext Registration info, removed pa… by tjcouch-sil · Pull Request #19 · paranext/paratext-10-studio Added button linking to Paratext Registration when getting projects for S/R fails by tjcouch-sil · Pull Request #80 · paranext/paratext-bible-internal-extensions

Documentation changes: Can't use GitHub password · paranext/paratext-10-studio@0b82fc9