paranoya / population-synthesis-toolkit

Spetral synthesis, photometry, etc. (to be eventually merged into SPiCE?)
BSD 3-Clause "New" or "Revised" License
1 stars 1 forks source link

Change name compute_sed to compute_L_lambda #7

Open Danieljl96 opened 3 weeks ago

Danieljl96 commented 3 weeks ago

To let the user know beforehand the units of the spectrum.

PabloCorcho commented 3 weeks ago

A couple of things about this:

paranoya commented 1 week ago

As noted in https://github.com/paranoya/population-synthesis-toolkit/pull/8, we should implement a compute_photometry method (or compute_flux_densities, as called by @Danieljl96; in any case, we should use the same name in both classes) that is equivalent to compute_SED (or compute_L_lambda), using ssp.photometry instead of ssp.L_lambda.

Alternatively, we may modify compute SED to let the user choose between the spectral luminosity L_lambda for all wavelengths (the current behaviour), the spectral flux densities F_nu in the requested bands (orders of magnitude faster!), or both.

Regarding the naming convention, I must agree with @PabloCorcho, even though I find sed, f_nu, and especially l_lambda a little bit weird...