search

parca-dev / parca

Continuous profiling for analysis of CPU and memory usage, down to the line number and throughout time. Saving infrastructure cost, improving performance, and increasing reliability.
https://parca.dev/
Apache License 2.0
4.06k stars 210 forks source link

ui: Revamp visualization toolbar to allow for additional graphs/graph combinations #1423

Open monicawoj opened 2 years ago

monicawoj commented 2 years ago

Once we add in the callgraph, the top right of the profile visualization toolbar will need to change as the "Table - Both - Icicle" buttons won't be enough to cover all our view use cases. I have put a design together in Figma that I think could be sustainable as we add other vis types: https://www.figma.com/file/zLNP6IQ0Q3cAtmVjZ85Glj/Polar-Signals-Cloud-App---Draft-03.2022?node-id=1651%3A1457. Basically the "+" button would allow the user to add another panel. The user can then choose what they want this panel to be filled with. Once the panel is filled, the "Add panel" button will become disabled so that we limit the view to only two panels. In the suggested design, the "Download pprof" and "Share profile" buttons are streamlined into icon buttons similar to the "Add Panel" button. Ideally on hover, we would have text info of what that button is.

monicawoj commented 2 years ago

Retain the view to two panels, as >2 may be overwhelming visually